Skip to contentSkip to conversation

powerpc: Reserve syscall number 319

PATCH In review Benjamin Herrenschmidt 4 participants 11 messages Sep 2, 2008 – Sep 3, 2008 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Reserve syscall number 319

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

---

I wonder if I'll get hanged for that one :-)

 arch/powerpc/include/asm/systbl.h |    1 +
 arch/powerpc/include/asm/unistd.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/systbl.h +1 -0
@@ -322,3 +322,4 @@ SYSCALL_SPU(epoll_create1)
 SYSCALL_SPU(dup3)
 SYSCALL_SPU(pipe2)
 SYSCALL(inotify_init1)
+SYSCALL(ni_syscall)
arch/powerpc/include/asm/unistd.h +2 -1
Index: linux-work/arch/powerpc/include/asm/unistd.h
===================================================================
@@ -341,10 +341,11 @@
 #define __NR_dup3		316
 #define __NR_pipe2		317
 #define __NR_inotify_init1	318
+/* 319 is reserved */
 
 #ifdef __KERNEL__
 
-#define __NR_syscalls		319
+#define __NR_syscalls		320
 
 #define __NR__exit __NR_exit
 #define NR_syscalls	__NR_syscalls
#1 lore raw
Quoted 4 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

Quoted 8 lines

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

---

I wonder if I'll get hanged for that one :-)

Is it a powerpc-specific syscall? If so... ew?

josh

#2 lore raw
Quoted 9 lines · Josh Boyer
Quoted 8 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

Quoted 6 lines
Quoted 4 lines

---

I wonder if I'll get hanged for that one :-)

Is it a powerpc-specific syscall? If so... ew?

Yes :-)

Ben.

#3 lore raw
In reply to Benjamin Herrenschmidt
Quoted 4 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

Quoted 8 lines

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

---

I wonder if I'll get hanged for that one :-)

Yes. Merge your code or live with the pain of things changing underneath. Period.

-Olof

#4 lore raw
Quoted 9 lines · Olof Johansson
Quoted 8 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

Quoted 7 lines
Quoted 4 lines

---

I wonder if I'll get hanged for that one :-)

Yes. Merge your code or live with the pain of things changing underneath. Period.

Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-)

Ben.

#5 lore raw
Quoted 13 lines · Benjamin Herrenschmidt
Quoted 12 lines · Olof Johansson
Quoted 11 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

---

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

I wonder if I'll get hanged for that one :-)

Yes. Merge your code or live with the pain of things changing underneath. Period.

Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-)

Lame excuse. Merge the code.

-Olof

#6 lore raw
Quoted 16 lines · Olof Johansson
Quoted 15 lines · Benjamin Herrenschmidt
Quoted 14 lines · Olof Johansson
Quoted 12 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

---

I wonder if I'll get hanged for that one :-)

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Yes. Merge your code or live with the pain of things changing underneath. Period.

Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-)

Lame excuse. Merge the code.

man, you know as well as I do I can't do that before the lawyers let me :-)

Ben.

#7 lore raw
Quoted 20 lines · Benjamin Herrenschmidt
Quoted 19 lines · Olof Johansson
Quoted 18 lines · Benjamin Herrenschmidt
Quoted 16 lines · Olof Johansson
Quoted 4 lines · Benjamin Herrenschmidt

Some stuff I'm working on that isn't released yet needs a syscall number but I can't say what it's for until I get permission to release it :-)

Quoted 8 lines

In the meantime, it would be nice if a number could be set aside so the tools being developped to use that stuff don't all need to be updated when things are eventually released.

---

I wonder if I'll get hanged for that one :-)

Yes. Merge your code or live with the pain of things changing underneath. Period.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-)

Lame excuse. Merge the code.

man, you know as well as I do I can't do that before the lawyers let me :-)

Then don't try to reserve a system call to be used only by an out-of-tree, proprietary kernel extension. Which your kernel change in essence is until it's released.

Would we accept a system call number reservation that was submitted by, say, nVidia? No? Well, there you go.

It's really that simple.

-Olof

#8 lore raw
Quoted 9 lines

Then don't try to reserve a system call to be used only by an out-of-tree, proprietary kernel extension. Which your kernel change in essence is until it's released.

Would we accept a system call number reservation that was submitted by, say, nVidia? No? Well, there you go.

It's really that simple.

Well, except that nvidia has no intention to release :-)

Anyway, it's a moot point, I have the answer I needed...

Cheers,
Ben.

#9 lore raw
In reply to Benjamin Herrenschmidt
Quoted 5 lines · Benjamin Herrenschmidt
Quoted 2 lines

Yes. Merge your code or live with the pain of things changing underneath. Period.

Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-)

They can wait until it's released. And there's of course no guarantee that your syscall will stand public review.

#10 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 5 lines · Benjamin Herrenschmidt
Quoted 2 lines

Yes. Merge your code or live with the pain of things changing underneath. Period.

Pain isn't for me :-) It's for those writing userspace stuff based on my kernel changing all the time :-)

They can wait until it's released. And there's of course no guarantee that your syscall will stand public review.

Yup. Definitely. I'm not even 100% sure we'll stick to a syscall in the long run. In the meantime, for internal purposes, it's easy enough to use an unused number to avoid further changes or stick a trampoline in the vdso :-)

Cheers,
Ben.