Skip to contentSkip to conversation

async_tx fix for 2.6.27-rc

GIT PULL Dan Williams 1 participant 1 message Sep 5, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Linus, please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/djbw/async_tx.git fixes

...to receive:

commit de24125dd0a452bfd4502fc448e3534c5d2e87aa

Author: Yuri Tikhonov <[email protected]>
Date:   Fri Sep 5 08:15:47 2008 -0700

async_tx: fix the bug in async_tx_run_dependencies

Should clear the next pointer of the TX if we are sure that the next TX (say NXT) will be submitted to the channel too. Overwise, we break the chain of descriptors, because we lose the information about the next descriptor to run. So next time, when invoke async_tx_run_dependencies() with TX, it's TX->next will be NULL, and NXT will be never submitted.

---
 crypto/async_tx/async_tx.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
crypto/async_tx/async_tx.c +2 -1
index 85eaf7b..e8362c1 100644
@@ -137,7 +137,8 @@ async_tx_run_dependencies(struct dma_async_tx_descriptor *tx)
 		spin_lock_bh(&next->lock);
 		next->parent = NULL;
 		_next = next->next;
-		next->next = NULL;
+		if (_next && _next->chan == chan)
+			next->next = NULL;
 		spin_unlock_bh(&next->lock);
 
 		next->tx_submit(next);