dyn_array: remove one panic
PATCH 1/1 dyn_array: remove one panic
Andrew said, we don't need duplicated panic.
because __alloc_bootmem already have that.
Signed-off-by Yinghai Lu <[email protected]>
init/dyn_array.c +2 -4
@@ -33,11 +33,9 @@ void __init pre_alloc_dyn_array(void)/* allocate them all together */ max_align = max_t(unsigned long, max_align, PAGE_SIZE); - ptr =__alloc_bootmem_nopanic (total_size, max_align,0 ); -if (!ptr) -panic ("Can not alloc dyn_alloc\n" ); - + ptr =__alloc_bootmem (total_size, max_align,0 ); phys =virt_to_phys (ptr); +for (daa = __dyn_array_start ; daa < __dyn_array_end; daa++) {struct dyn_array *da = *daa;
Ingo Molnar
AppliedQuoted 4 lines · Yinghai Lu
Andrew said, we don't need duplicated panic.
because__alloc_bootmemalready have that.Signed-off-by Yinghai Lu <[email protected]>
applied to tip/irq/sparseirq, thanks.
Maybe some design documentation would be nice too, to point out that most of the pain we do here is because we dont have bootmem available as early as we need an already instantiated dyn-array based IRQ array.
So we try this mix of an abstraction of preallocated and post-allocated array, with pre-bootmem and post-bootmem behavior.
Ingo