Remove CONFIG_SHOW_ACTIVITY from stx boards which don't support it
PATCH 1/1 Remove CONFIG_SHOW_ACTIVITY from stx boards which don't support it
commit 9cff4448a9cb882defe6c8bde73b77fc0c636799 removed the mpc85xx version of timer_interrupt, which was overriding the lib_ppc version. The lib_ppc version tries to invoke board_show_activity() if CONFIG_SHOW_ACTIVITY is defined. stxgp3 and stxssa defined it, despite not defining board_show_activity(). I'll leave it to the stx* maintainer to implement that function if desired. :)
--- include/configs/stxgp3.h | 4 ---- include/configs/stxssa.h | 4 ---- 2 files changed, 0 insertions(+), 8 deletions(-)
include/configs/stxgp3.h +0 -4
@@ -55,10 +55,6 @@#define CONFIG_SYS_CLK_FREQ 33333333/* most pci cards are 33Mhz */ -/* Blinkin' LEDs for Robert :-) -*/ -#define CONFIG_SHOW_ACTIVITY 1 -/* * These can be toggled for performance analysis, otherwise use default. */
include/configs/stxssa.h +0 -4
@@ -55,10 +55,6 @@#define CONFIG_SYS_CLK_FREQ 33000000/* most pci cards are 33Mhz */ -/* Blinkin' LEDs for Robert :-) -*/ -#define CONFIG_SHOW_ACTIVITY 1 -/* * These can be toggled for performance analysis, otherwise use default. */
Signature · 1 line
1.5.4.GIT
Wolfgang Denk
NAKPATCH 1/1 Remove CONFIG_SHOW_ACTIVITY from stx boards which don't support it
Dear Andy Fleming,
Quoted 6 lines · In message <[email protected]> you wrote:
commit
9cff4448a9cb882defe6c8bde73b77fc0c636799removed the mpc85xx version oftimer_interrupt, which was overriding thelib_ppcversion. Thelib_ppcversion tries to invokeboard_show_activity()ifCONFIG_SHOW_ACTIVITYis defined. stxgp3 and stxssa defined it, despite not definingboard_show_activity(). I'll leave it to the stx* maintainer to implement that function if desired. :)
Your patch is incorrect as it not only disables board_show_activity() which indeed is not implemented on these boards, but it also disables show_activity() which *is* implemented and shall not be touched.
NAK!
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Though a program be but three lines long, someday it will have to be maintained." - The Tao of Programming