Skip to contentSkip to conversation

bootm: Add sub commands

RFC In review Kumar Gala 4 participants 11 messages Sep 17, 2008 – Sep 22, 2008

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

RFC 1/1 bootm: Add sub commands

Posting this again for discussion. The two features I'm interested in enabling are:

* Having the ability to modify the device tree before its passed to the kernel but after 'fdt boardsetup'

* Ability to do all setup but not actually jumping to the kernel. (This is useful as a way to setup the memory image [kernel, ramdisk, fdt, etc] for a different cpu than the boot one)

Having bootm sub-commands allows both of these as we can break up the sequeunce of steps that are part of the bootm process.

- k

---
 common/cmd_bootm.c |  112 +++++++++++++++++++++++++++
 include/image.h    |   11 +++
 lib_ppc/bootm.c    |  212 ++++++++++++++++++++++++++++++----------------------
 3 files changed, 244 insertions(+), 91 deletions(-)
common/cmd_bootm.c +112 -0
index 19257bb..0f6bd06 100644
@@ -34,6 +34,7 @@
 #include <bzlib.h>
 #include <environment.h>
 #include <lmb.h>
+#include <linux/ctype.h>
 #include <asm/byteorder.h>
 
 #if defined(CONFIG_CMD_USB)
@@ -376,6 +377,89 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
 	return 0;
 }
 
+int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int ret = 0;
+
+	/* start */
+	if (argv[1][0] == 's') {
+		argc--;
+		argv++;
+		return bootm_start(cmdtp, flag, argc, argv);
+	}
+
+	if (!images.valid) {
+		printf("Need to call %s start first\n", argv[0]);
+		return 1;
+	}
+
+	/* load os */
+	if (argv[1][0] == 'l') {
+		ulong load_end;
+		ret = bootm_load_os(images.os, &load_end, 0);
+		if (ret)
+			return ret;
+
+		lmb_reserve(&images.lmb, images.os.load,
+				(load_end - images.os.load));
+
+		return ret;
+	}
+	/* initrd relocate */
+#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
+	else if (argv[1][0] == 'i') {
+		ulong rd_len = images.rd_end - images.rd_start;
+		char str[17];
+
+		ret = boot_ramdisk_high(&images.lmb, images.rd_start,
+			rd_len, &images.initrd_start, &images.initrd_end);
+		if (ret)
+			return ret;
+
+		sprintf(str, "%lx", images.initrd_start);
+		setenv("initrd_start", str);
+		sprintf(str, "%lx", images.initrd_end);
+		setenv("initrd_end", str);
+
+		return ret;
+	}
+#endif
+#ifdef CONFIG_OF_LIBFDT
+	/* fdt relocate */
+	else if (argv[1][0] == 'f') {
+		ulong bootmap_base = getenv_bootm_low();
+		ret = boot_relocate_fdt(&images.lmb, bootmap_base,
+			&images.ft_addr, &images.ft_len);
+	}
+#endif
+#if 0
+are these really common ??? or is there any harm??
+	/* bd_t setup */
+	else if (argv[1][0] == 'p') {
+	}
+	/* cmd setup */
+	else if (argv[1][0] == 'c') {
+	}
+#endif
+	/* prep os */
+	else if (argv[1][0] == 'p') {
+		return do_bootm_linux(BOOT_OS_PREP, argc, argv, &images);
+	}
+	/* go */
+	else if (argv[1][0] == 'g') {
+		disable_interrupts();
+		do_bootm_linux(BOOT_OS_GO, argc, argv, &images);
+		return 0;
+	}
+	else {
+		/* Unrecognized command */
+		printf ("Usage:\n%s\n", cmdtp->usage);
+		return 1;
+	}
+
+	return ret;
+}
+
 /*******************************************************************/
 /* bootm - boot application image from image in memory */
 /*******************************************************************/
@@ -386,6 +470,23 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	ulong		load_end = 0;
 	int		ret;
 
+	/* determine if we have a sub command */
+	if (argc > 1) {
+		char *endp;
+
+		simple_strtoul(argv[1], &endp, 16);
+		/* endp pointing to NULL means that argv[1] was just a
+		 * valid number, pass it along to the normal bootm processing
+		 *
+		 * If endp is ':' or '#' assume a FIT identifier so pass
+		 * along for normal processing.
+		 *
+		 * Right now we assume the first arg should never be '-'
+		 */
+		if ((*endp != 0) && (*endp != ':') && (*endp != '#'))
+			return do_bootm_subcommand(cmdtp, flag, argc, argv);
+	}
+
 	if (bootm_start(cmdtp, flag, argc, argv))
 		return 1;
 
@@ -782,6 +883,17 @@ U_BOOT_CMD(
 	"\tUse iminfo command to get the list of existing component\n"
 	"\timages and configurations.\n"
 #endif
+	"\t\nSub-commands to do part of the bootm sequence:\n"
+	"\tstart [addr [arg ...]]\n"
+	"\tloados - load OS image\n"
+	"\tprepos - OS specific prep before relocation or go\n"
+#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
+	"\tinitrd - relocate initrd, set env initrd_start/initrd_end\n"
+#endif
+#if defined(CONFIG_OF_LIBFDT)
+	"\tfdt - relocate initrd\n"
+#endif
+	"\tgo - start os\n"
 );
 
 /*******************************************************************/
include/image.h +11 -0
index 82e6345..2c323ab 100644
@@ -228,6 +228,7 @@ typedef struct bootm_headers {
 #endif
 #endif
 
+#ifndef USE_HOSTCC
 	image_info_t	os;		/* os image info */
 	ulong		ep;		/* entry point of OS */
 
@@ -238,6 +239,13 @@ typedef struct bootm_headers {
 #endif
 	ulong		ft_len;		/* length of flat device tree */
 
+	ulong		initrd_start;
+	ulong		initrd_end;
+	ulong		cmdline_start;
+	ulong		cmdline_end;
+	bd_t		*kbd;
+#endif
+
 	int		verify;		/* getenv("verify")[0] != 'n' */
 	int		valid;		/* set to 1 if we've set values in the header */
 #ifndef USE_HOSTCC
@@ -640,4 +648,7 @@ static inline int fit_image_check_target_arch (const void *fdt, int node)
 #endif /* CONFIG_FIT_VERBOSE */
 #endif /* CONFIG_FIT */
 
+#define BOOT_OS_PREP	0x01
+#define BOOT_OS_GO	0x02
+
 #endif	/* __IMAGE_H__ */
lib_ppc/bootm.c +121 -91

280 lines not on this page · raw message

Signature · 1 line
1.5.5.1
#1 lore raw
Quoted 6 lines · Kumar Gala

Posting this again for discussion. The two features I'm interested in enabling are:

* Having the ability to modify the device tree before its passed to the kernel but after 'fdt boardsetup'

Quoted 8 lines

* Ability to do all setup but not actually jumping to the kernel. (This is useful as a way to setup the memory image [kernel, ramdisk, fdt, etc] for a different cpu than the boot one)

Having bootm sub-commands allows both of these as we can break up the sequeunce of steps that are part of the bootm process.

- k

Hi Kumar,

Looks like a good proposal. I've been rather distracted the last couple of weeks, but I'll put some eyeball time and runtime on your changes.

[snip]

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 439

Quoted 5 lines
common/cmd_bootm.c +5 -0
+#if 0
+are these really common ??? or is there any harm??
+	/* bd_t setup */
+	else if (argv[1][0] == 'p') {
+	}

If we are using a FDT, there is no reason for a bd_t as part of the boot process. I vote for removal.
(typo s/p/b/?)

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 442

Quoted 3 lines
common/cmd_bootm.c +3 -0
+	/* cmd setup */
+	else if (argv[1][0] == 'c') {
+	}

I don't know what "cmd setup" is/was off-hand, have to look into that. Probably also a removal.

[snip]

common/cmd_bootm.c U_BOOT_CMD( · line 894

Quoted 13 lines
common/cmd_bootm.c +9 -0
@@ -782,6 +883,17 @@ U_BOOT_CMD(
 	"\tUse iminfo command to get the list of existing component\n"
 	"\timages and configurations.\n"
 #endif
+	"\t\nSub-commands to do part of the bootm sequence:\n"
+	"\tstart [addr [arg ...]]\n"
+	"\tloados - load OS image\n"
+	"\tprepos - OS specific prep before relocation or go\n"
+#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
+	"\tinitrd - relocate initrd, set env initrd_start/initrd_end\n"
+#endif
+#if defined(CONFIG_OF_LIBFDT)
+	"\tfdt - relocate initrd\n"

Cut'n'paste? s/initrd/the flattened device tree/

[snip]

Quoted 30 lines
lib_ppc/bootm.c +2 -11
index 38266e1..208ed3b 100644
@@ -47,6 +47,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);
 extern ulong get_effective_memsize(void);
 static ulong get_sp (void);
 static void set_clocks_in_mhz (bd_t *kbd);
@@ -55,30 +56,78 @@ static void set_clocks_in_mhz (bd_t *kbd);
 #define CFG_LINUX_LOWMEM_MAX_SIZE	(768*1024*1024)
 #endif
 
-__attribute__((noinline))
-int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
+static void boot_jump_linux(bootm_headers_t *images)
 {
-	ulong	sp;
-
-	ulong	initrd_start, initrd_end;
-	ulong	rd_len;
-	ulong	size;
-	phys_size_t bootm_size;
-
-	ulong	cmd_start, cmd_end, bootmap_base;
-	bd_t	*kbd;
 	void	(*kernel)(bd_t *, ulong r4, ulong r5, ulong r6,

lib_ppc/bootm.c static void set_clocks_in_mhz (bd_t *kbd); · line 68

Quoted 10 lines
lib_ppc/bootm.c +6 -3
 			  ulong r7, ulong r8, ulong r9);
-	int	ret;
-	ulong	of_size = images->ft_len;
-	struct lmb *lmb = &images->lmb;
+
+	kernel = (void (*)(bd_t *, ulong, ulong, ulong,
+			   ulong, ulong, ulong))images->ep;
+#ifdef CONFIG_OF_LIBFDT
+	char *of_flat_tree = images->ft_addr;
+#endif

This should be moved above the "kernel = " line to keep it with the rest of the declarations, yes?

[big snip]

Thanks!
gvb

author
#2 lore raw
Quoted 13 lines · Jerry Van Baren
Quoted 11 lines · Kumar Gala

Posting this again for discussion. The two features I'm interested in
enabling are:
* Having the ability to modify the device tree before its passed to the kernel but after 'fdt boardsetup'
* Ability to do all setup but not actually jumping to the kernel. (This is useful as a way to setup the memory image [kernel, ramdisk, fdt, etc] for a different cpu than the boot one)
Having bootm sub-commands allows both of these as we can break up the sequeunce of steps that are part of the bootm process.
- k

Quoted 5 lines

Hi Kumar,

Looks like a good proposal. I've been rather distracted the last couple of weeks, but I'll put some eyeball time and runtime on your changes.

thanks

Quoted 9 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 439

Quoted 5 lines
common/cmd_bootm.c +5 -0
+#if 0
+are these really common ??? or is there any harm??
+	/* bd_t setup */
+	else if (argv[1][0] == 'p') {
+	}

If we are using a FDT, there is no reason for a bd_t as part of the boot process. I vote for removal.
(typo s/p/b/?)

should be 'b'

Quoted 8 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 442

Quoted 5 lines
common/cmd_bootm.c +3 -0
+	/* cmd setup */
+	else if (argv[1][0] == 'c') {
+	}

I don't know what "cmd setup" is/was off-hand, have to look into that. Probably also a removal.

cmdline

Quoted 1 line

[snip]

Sounds like WD thinks we need this for supporting 2.4 kernels.

Quoted 17 lines
Quoted 4 lines
common/cmd_bootm.c +0 -0
@@ -782,6 +883,17 @@ U_BOOT_CMD(
 	"\tUse iminfo command to get the list of existing component\n"
 	"\timages and configurations.\n"
 #endif

common/cmd_bootm.c U_BOOT_CMD( · line 895

Quoted 10 lines
common/cmd_bootm.c +9 -0
+	"\t\nSub-commands to do part of the bootm sequence:\n"
+	"\tstart [addr [arg ...]]\n"
+	"\tloados - load OS image\n"
+	"\tprepos - OS specific prep before relocation or go\n"
+#if defined(CONFIG_PPC) || defined(CONFIG_M68K) ||  
 defined(CONFIG_SPARC)
+	"\tinitrd - relocate initrd, set env initrd_start/initrd_end\n"
+#endif
+#if defined(CONFIG_OF_LIBFDT)
+	"\tfdt - relocate initrd\n"

Cut'n'paste? s/initrd/the flattened device tree/

Quoted 1 line

[snip]

yep, fixed.

Quoted 43 lines
Quoted 29 lines
lib_ppc/bootm.c +2 -11
index 38266e1..208ed3b 100644
@@ -47,6 +47,7 @@
 DECLARE_GLOBAL_DATA_PTR;
+extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char  
 *argv[]);
 extern ulong get_effective_memsize(void);
 static ulong get_sp (void);
 static void set_clocks_in_mhz (bd_t *kbd);
@@ -55,30 +56,78 @@ static void set_clocks_in_mhz (bd_t *kbd);
 #define CFG_LINUX_LOWMEM_MAX_SIZE	(768*1024*1024)
 #endif
-__attribute__((noinline))
-int do_bootm_linux(int flag, int argc, char *argv[],  
 bootm_headers_t *images)
+static void boot_jump_linux(bootm_headers_t *images)
 {
-	ulong	sp;
-
-	ulong	initrd_start, initrd_end;
-	ulong	rd_len;
-	ulong	size;
-	phys_size_t bootm_size;
-
-	ulong	cmd_start, cmd_end, bootmap_base;
-	bd_t	*kbd;
 	void	(*kernel)(bd_t *, ulong r4, ulong r5, ulong r6,

lib_ppc/bootm.c static void set_clocks_in_mhz (bd_t *kbd); · line 68

Quoted 10 lines
lib_ppc/bootm.c +6 -3
 			  ulong r7, ulong r8, ulong r9);
-	int	ret;
-	ulong	of_size = images->ft_len;
-	struct lmb *lmb = &images->lmb;
+
+	kernel = (void (*)(bd_t *, ulong, ulong, ulong,
+			   ulong, ulong, ulong))images->ep;
+#ifdef CONFIG_OF_LIBFDT
+	char *of_flat_tree = images->ft_addr;
+#endif

This should be moved above the "kernel = " line to keep it with the rest of the declarations, yes?

Quoted 1 line

[big snip]

yep, fix.

- k

#3 lore raw
In reply to Kumar Gala

Dear Kumar Gala,

Quoted 3 lines · In message <[email protected]> you…

Having bootm sub-commands allows both of these as we can break up the sequeunce of steps that are part of the bootm process.

OK.

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 385

Quoted 6 lines
common/cmd_bootm.c +6 -0
+int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int ret = 0;
+
+	/* start */
+	if (argv[1][0] == 's') {

I think just matching on the first letter is to restrictive; we'll end up with artificical command "names" that nobody can remember.

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 394

Quoted 4 lines
common/cmd_bootm.c +4 -0
+	if (!images.valid) {
+		printf("Need to call %s start first\n", argv[0]);
+		return 1;
+	}

We should probably set up a small state machine.

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 410

Quoted 1 line
common/cmd_bootm.c +1 -0
+	else if (argv[1][0] == 'i') {

And we need comments what all this means. WTF is 'i' ?

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 439

Quoted 5 lines
common/cmd_bootm.c +5 -0
+#if 0
+are these really common ??? or is there any harm??
+	/* bd_t setup */
+	else if (argv[1][0] == 'p') {
+	}

Yes, we still have plenty of systems running in the field with arch/ppc and even with 2.4 kernels.

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 447

Quoted 4 lines
common/cmd_bootm.c +4 -0
+	/* prep os */
+	else if (argv[1][0] == 'p') {
+		return do_bootm_linux(BOOT_OS_PREP, argc, argv, &images);
+	}

We already had 'p' above.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There was no difference between  the  behavior  of  a  god  and  the
operations of pure chance..."   - Thomas Pynchon, _Gravity's Rainbow_
#4 lore raw
Quoted 8 lines · Wolfgang Denk

Dear Kumar Gala,

Quoted 2 lines · In message <[email protected]> you…

Having bootm sub-commands allows both of these as we can break up the sequeunce of steps that are part of the bootm process.

OK.

Quoted 9 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 385

Quoted 6 lines
common/cmd_bootm.c +6 -0
+int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int ret = 0;
+
+	/* start */
+	if (argv[1][0] == 's') {

I think just matching on the first letter is to restrictive; we'll end up with artificical command "names" that nobody can remember.

That is what the all the other command subcommands do: match on the minimum unique sequence, preferably one letter.

Quoted 3 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 410

Quoted 1 line
common/cmd_bootm.c +1 -0
+	else if (argv[1][0] == 'i') {

And we need comments what all this means. WTF is 'i' ?

Ich in German :-D (That is a bad cross-lingual pun: "ick" is what you say in English when you step in dog poo.)

You snipped the preceding comment line. Granted, it was pretty terse:

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 408

Quoted 1 line
common/cmd_bootm.c +1 -0
+	/* initrd relocate */

The "help" string helps:

Quoted 16 lines
common/cmd_bootm.c +11 -0
@@ -782,6 +883,17 @@ U_BOOT_CMD(
 	"\tUse iminfo command to get the list of existing component\n"
 	"\timages and configurations.\n"
 #endif
+	"\t\nSub-commands to do part of the bootm sequence:\n"
+	"\tstart [addr [arg ...]]\n"
+	"\tloados - load OS image\n"
+	"\tprepos - OS specific prep before relocation or go\n"
+#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
+	"\tinitrd - relocate initrd, set env initrd_start/initrd_end\n"
+#endif
+#if defined(CONFIG_OF_LIBFDT)
+	"\tfdt - relocate initrd\n"
+#endif
+	"\tgo - start os\n"
 );

[snip]

Quoted 3 lines

Best regards,

Wolfgang Denk

Ditto,
gvb

author
#5 lore raw
In reply to Wolfgang Denk
Quoted 10 lines · Wolfgang Denk

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 385

Quoted 7 lines

+int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])

common/cmd_bootm.c +5 -0
+{
+	int ret = 0;
+
+	/* start */
+	if (argv[1][0] == 's') {

I think just matching on the first letter is to restrictive; we'll end up with artificical command "names" that nobody can remember.

I'm happy to move to using strncmp, but I agree with Jerry that other subcommand do the shortest match possible.

- k

#6 lore raw

Dear Kumar Gala,

Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 6 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 385

Quoted 3 lines
common/cmd_bootm.c +2 -0
+	/* start */
+	if (argv[1][0] == 's') {

I think just matching on the first letter is to restrictive; we'll end up with artificical command "names" that nobody can remember.

I'm happy to move to using strncmp, but I agree with Jerry that other subcommand do the shortest match possible.

Agreed. The shortest unambiguous match shall be sufficient. On the other hand we should allow for longer subcopmmand names, or we'll very soon see artifical command identifiers that nobody can remember well because they were artificially chosen to use a still unused letter.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have made mistakes, but have never made the mistake of  claiming  I
never made one.                                     - James G. Bennet
author
#7 lore raw
In reply to Wolfgang Denk
Quoted 11 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 385

Quoted 7 lines

+int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])

common/cmd_bootm.c +5 -0
+{
+	int ret = 0;
+
+	/* start */
+	if (argv[1][0] == 's') {

I think just matching on the first letter is to restrictive; we'll end up with artificical command "names" that nobody can remember.

Quoted 6 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 394

Quoted 4 lines
common/cmd_bootm.c +4 -0
+	if (!images.valid) {
+		printf("Need to call %s start first\n", argv[0]);
+		return 1;
+	}

We should probably set up a small state machine.

A small state machine for what?

Quoted 3 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 410

Quoted 1 line
common/cmd_bootm.c +1 -0
+	else if (argv[1][0] == 'i') {

And we need comments what all this means. WTF is 'i' ?

initrd, I can change it to 'r' for ramdisk if that is better.

Quoted 9 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 439

Quoted 5 lines
common/cmd_bootm.c +5 -0
+#if 0
+are these really common ??? or is there any harm??
+	/* bd_t setup */
+	else if (argv[1][0] == 'p') {
+	}

Yes, we still have plenty of systems running in the field with arch/ppc and even with 2.4 kernels.

Quoted 6 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 447

Quoted 4 lines
common/cmd_bootm.c +4 -0
+	/* prep os */
+	else if (argv[1][0] == 'p') {
+		return do_bootm_linux(BOOT_OS_PREP, argc, argv, &images);
+	}

We already had 'p' above.

- k

#8 lore raw

Dear Kumar Gala,

Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 7 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 394

Quoted 5 lines
common/cmd_bootm.c +4 -0
+	if (!images.valid) {
+		printf("Need to call %s start first\n", argv[0]);
+		return 1;
+	}

We should probably set up a small state machine.

A small state machine for what?

Well, we have states - here you code that a certain operation is not
allowed unless something else has been done before. SImilar
dependencies may follow - after uncompressing and loading the kernel image it might for example be not allowed any more to turn on interrupts, etc. Of course we can handle all this in a maze of conditional statements. Or we could use a small state machine.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Conscious is when you are aware of something, and conscience is  when
you wish you weren't.
author
#9 lore raw
Quoted 12 lines · Wolfgang Denk

Dear Kumar Gala,

In message <CF82B92D-9821-495A-

Quoted 8 lines · AA5A-192B83C8619E at kernel.crashing.org> you wrote:
Quoted 7 lines

common/cmd_bootm.c static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress) · line 394

Quoted 5 lines
common/cmd_bootm.c +4 -0
+	if (!images.valid) {
+		printf("Need to call %s start first\n", argv[0]);
+		return 1;
+	}

We should probably set up a small state machine.

Quoted 8 lines
Quoted 1 line

A small state machine for what?

Well, we have states - here you code that a certain operation is not
allowed unless something else has been done before. SImilar
dependencies may follow - after uncompressing and loading the kernel image it might for example be not allowed any more to turn on interrupts, etc. Of course we can handle all this in a maze of conditional statements. Or we could use a small state machine.

So I'm not sure I completely understand what this state machine would look like that you are thinking about.

I get the issue, just not seeing the implementation you are thinking about.

- k

#10 lore raw

Dear Kumar,

Quoted 10 lines · in message <[email protected]> you wrote:
Quoted 7 lines

Well, we have states - here you code that a certain operation is not
allowed unless something else has been done before. SImilar
dependencies may follow - after uncompressing and loading the kernel image it might for example be not allowed any more to turn on interrupts, etc. Of course we can handle all this in a maze of conditional statements. Or we could use a small state machine.

So I'm not sure I completely understand what this state machine would look like that you are thinking about.

It would describe legal state changes - each sub-command would only be allowed in a certain set of states, and if run cause a transition into another state.

Quoted 2 lines

I get the issue, just not seeing the implementation you are thinking about.

He, implementation. The details are left to the reader :-)

Sorry, I'm not even thinking about any actual code yet.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't care.  We don't have to.  We're the Phone Company."