x86: suppress trivial sparse signedness warnings
PATCH 1/1 x86: suppress trivial sparse signedness warnings
Could just as easily change the three casts to cast to the correct type...this patch changes the type of ftrace_nop instead.
Supresses sparse warnings:arch/x86/kernel/ftrace.c:157:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:157:14: expected long *static [toplevel] ftrace_noparch/x86/kernel/ftrace.c:157:14: got unsigned long *<noident>arch/x86/kernel/ftrace.c:161:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:161:14: expected long *static [toplevel] ftrace_noparch/x86/kernel/ftrace.c:161:14: got unsigned long *<noident>arch/x86/kernel/ftrace.c:165:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:165:14: expected long *static [toplevel] ftrace_noparch/x86/kernel/ftrace.c:165:14: got unsigned long *<noident>
--- arch/x86/kernel/ftrace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/ftrace.c +1 -1
@@ -22,7 +22,7 @@/* Long is fine, even if it is only 4 bytes ;-) */ -static long *ftrace_nop; +static unsigned long *ftrace_nop;union ftrace_code_union {char code[MCOUNT_INSN_SIZE ];
Signature · 1 line
1.6.0.2.471.g47a76
This should probably go to Steven...
Quoted 37 lines · * Harvey Harrison ([email protected]) wrote:
Could just as easily change the three casts to cast to the correct type...this patch changes the type of
ftrace_nopinstead.Supresses sparse warnings:
arch/x86/kernel/ftrace.c:157:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:157:14: expected long *static [toplevel]ftrace_noparch/x86/kernel/ftrace.c:157:14: got unsigned long *<noident>arch/x86/kernel/ftrace.c:161:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:161:14: expected long *static [toplevel]ftrace_noparch/x86/kernel/ftrace.c:161:14: got unsigned long *<noident>arch/x86/kernel/ftrace.c:165:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:165:14: expected long *static [toplevel]ftrace_noparch/x86/kernel/ftrace.c:165:14: got unsigned long *<noident>Signed-off-by Harvey Harrison <[email protected]>--- arch/x86/kernel/ftrace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kernel/ftrace.c +1
-1@@ -22,7 +22,7 @@/* Long is fine, even if it is only 4 bytes ;-) */ -static long *ftrace_nop; +static unsigned long *ftrace_nop;union ftrace_code_union {char code[MCOUNT_INSN_SIZE ];Signature · 1 line
1.6.0.2.471.g47a76
Signature · 2 lines
Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
Ingo Molnar
AppliedQuoted 14 lines · Harvey Harrison
Could just as easily change the three casts to cast to the correct type...this patch changes the type of
ftrace_nopinstead.Supresses sparse warnings:
arch/x86/kernel/ftrace.c:157:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:157:14: expected long *static [toplevel]ftrace_noparch/x86/kernel/ftrace.c:157:14: got unsigned long *<noident>arch/x86/kernel/ftrace.c:161:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:161:14: expected long *static [toplevel]ftrace_noparch/x86/kernel/ftrace.c:161:14: got unsigned long *<noident>arch/x86/kernel/ftrace.c:165:14: warning: incorrect type in assignment (different signedness)arch/x86/kernel/ftrace.c:165:14: expected long *static [toplevel]ftrace_noparch/x86/kernel/ftrace.c:165:14: got unsigned long *<noident>
Quoted 1 line
Signed-off-by Harvey Harrison <[email protected]>
applied to tip/tracing/ftrace, thanks Harvey!
Ingo