Skip to contentSkip to conversation

Don't print an error message just because there's no i8042 chip

PATCH New Adam Jackson 3 participants 5 messages Sep 29, 2008 – Jun 3, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't print an error message just because there's no i8042 chip

From: Peter Jones <[email protected]>

Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior.

---
 drivers/input/serio/i8042.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/input/serio/i8042.c +1 -3
index 170f71e..4f3e632 100644
@@ -701,10 +701,8 @@ static int __devinit i8042_check_aux(void)
 
 static int i8042_controller_check(void)
 {
-	if (i8042_flush() == I8042_BUFFER_SIZE) {
-		printk(KERN_ERR "i8042.c: No controller found.\n");
+	if (i8042_flush() == I8042_BUFFER_SIZE)
 		return -ENODEV;
-	}
 
 	return 0;
 }
Signature · 1 line
1.6.0.1
#1 lore raw

PATCH 1/1 i8042: Don't print an error message just because there's no chip

From: Peter Jones <[email protected]>

Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior.

v2: Downgrade to pr_notice instead of pr_err.

---
 drivers/input/serio/i8042.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/i8042.c +1 -1
index 020053f..05c6285 100644
@@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
 static int i8042_controller_check(void)
 {
 	if (i8042_flush()) {
-		pr_err("No controller found\n");
+		pr_notice("No controller found\n");
 		return -ENODEV;
 	}
 
Signature · 1 line
1.8.5.3
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] i8042: Don't print an error message just because there's no chip

Quoted 9 lines · Adam Jackson

From: Peter Jones <[email protected]>

Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior.

v2: Downgrade to pr_notice instead of pr_err.

Quoted 17 lines
---
 drivers/input/serio/i8042.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/i8042.c +1 -1
index 020053f..05c6285 100644
@@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
 static int i8042_controller_check(void)
 {
        if (i8042_flush()) {
-               pr_err("No controller found\n");
+               pr_notice("No controller found\n");
                return -ENODEV;
        }
 
#3 lore raw

Re: [PATCH] i8042: Don't print an error message just because there's no chip

Quoted 7 lines · Josh Boyer
Quoted 6 lines · Adam Jackson

From: Peter Jones <[email protected]>

Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior.

Quoted 5 lines
Quoted 3 lines

v2: Downgrade to pr_notice instead of pr_err.

Ping? This patch or something like it has been pending since 2008 [1], would be nice to see it merged before it's old enough to start first grade.

[1] - https://lkml.org/lkml/2008/9/29/248

- ajax

Reviewed-by
#4 lore raw

Re: [PATCH] i8042: Don't print an error message just because there's no chip

Quoted 12 lines · Adam Jackson
Quoted 11 lines · Josh Boyer
Quoted 9 lines · Adam Jackson

From: Peter Jones <[email protected]>

Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior.

v2: Downgrade to pr_notice instead of pr_err.

Quoted 8 lines
Quoted 1 line

Ping? This patch or something like it has been pending since 2008 [1], would be nice to see it merged before it's old enough to start first grade.

[1] - https://lkml.org/lkml/2008/9/29/248

Hey Ajax,

regarding the input stuff, adding the maintainers always help. So adding Dmitry in CC.

BTW, the patch looks good enough:

Cheers,
Benjamin