Skip to contentSkip to conversation

kvmppc: fix set regs to take care of msr change implications

PATCH New [email protected] 1 participant 1 message Oct 2, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvmppc: fix set regs to take care of msr change implications

From: Christian Ehrhardt <[email protected]>

When changing some msr bits e.g. problem state we need to take special care of that. We call the function in our mtmsr emulation (not needed for wrtee[i]), but we don't call kvmppc_set_msr if we change msr via set_regs ioctl.
It's a corner case we never hit so far, but I assume it should be kvmppc_set_msr in our arch set regs function (I found it because it is also a corner case when using pv support which would miss the update otherwise).

---

[diffstat]

 booke_guest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[diff]

arch/powerpc/kvm/booke_guest.c +1 -1
@@ -584,7 +580,7 @@
 	vcpu->arch.ctr = regs->ctr;
 	vcpu->arch.lr = regs->lr;
 	vcpu->arch.xer = regs->xer;
-	vcpu->arch.msr = regs->msr;
+	kvmppc_set_msr(vcpu, regs->msr);
 	vcpu->arch.srr0 = regs->srr0;
 	vcpu->arch.srr1 = regs->srr1;
 	vcpu->arch.sprg0 = regs->sprg0;