Skip to contentSkip to conversation

serial: remove unused variable

PATCH In review Simon Holm Thøgersen 2 participants 3 messages Oct 13, 2008 – Oct 14, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: remove unused variable

This fixes the following compile warning:

drivers/serial/8250.c: In function 'serial8250_init':
drivers/serial/8250.c:2963: warning: unused variable 'i'

that was introduced by b70ac771 (serial: allow 8250 to be used on sparc) that removed the last use of the variable.

---
 drivers/serial/8250.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/8250.c +1 -1
index d4104a3..625fc20 100644
@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
 
 static int __init serial8250_init(void)
 {
-	int ret, i;
+	int ret;
 
 	if (nr_uarts > UART_NR)
 		nr_uarts = UART_NR;
Signature · 1 line
1.5.6.2.255.gbed62
#1 lore raw
Quoted 18 lines · Simon Holm Th�gersen

This fixes the following compile warning:

drivers/serial/8250.c: In function 'serial8250_init':
drivers/serial/8250.c:2963: warning: unused variable 'i'

that was introduced by b70ac771 (serial: allow 8250 to be used on sparc) that removed the last use of the variable.

---
drivers/serial/8250.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/8250.c +0 -0
index d4104a3..625fc20 100644

drivers/serial/8250.c EXPORT_SYMBOL(serial8250_unregister_port); · line 2966

Quoted 8 lines
drivers/serial/8250.c +1 -1
@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
 
 static int __init serial8250_init(void)
 {
-	int ret, i;
+	int ret;
 
 	if (nr_uarts > UART_NR)
 		nr_uarts = UART_NR;

I find those code in this function __init serial8250_init(void)

        for (i = 0; i < NR_IRQS; i++)
                spin_lock_init(&irq_lists[i].lock);

So you do not remove the 'i'.

Signature · 3 lines
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: [email protected]
#2 lore raw

tir, 14 10 2008 kl. 13:50 +0800, skrev Jianjun Kong:

Quoted 30 lines · Simon Holm Th�gersen
Quoted 18 lines

This fixes the following compile warning:

drivers/serial/8250.c: In function 'serial8250_init':
drivers/serial/8250.c:2963: warning: unused variable 'i'

that was introduced by b70ac771 (serial: allow 8250 to be used on sparc) that removed the last use of the variable.

---
drivers/serial/8250.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/8250.c +0 -0
index d4104a3..625fc20 100644

drivers/serial/8250.c EXPORT_SYMBOL(serial8250_unregister_port); · line 2966

Quoted 8 lines
drivers/serial/8250.c +1 -1
@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
 
 static int __init serial8250_init(void)
 {
-	int ret, i;
+	int ret;
 
 	if (nr_uarts > UART_NR)
 		nr_uarts = UART_NR;

I find those code in this function __init serial8250_init(void)

Quoted 5 lines
        for (i = 0; i < NR_IRQS; i++)
                spin_lock_init(&irq_lists[i].lock);

So you do not remove the 'i'.

Look at the referenced commit b70ac771 (serial: allow 8250 to be used on sparc). It is quite recent (Mon Oct 13 10:36:31 2008 +0100), but if you pull Linus' latest tree it is there.

Simon