Skip to contentSkip to conversation

tmp2-tss: remove architecture restriction

PATCH New Carlos Santos 2 participants 14 messages Mar 15, 2018 – Mar 21, 2018

lore
Share & tools
lore

Carlos Santos

author
#0 lore raw

PATCH 1/5 tmp2-tss: remove architecture restriction

Followingig a suggestion from Peter Korsgaard, remove the restriction to x86 and x86_64. It is preferable to expose the package unless there is a build time dependency on an architecture or the package is specific to a certain SoC or board.

Signed-off-by Carlos Santos <[email protected]>
---
 package/tpm2-tss/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/tpm2-tss/Config.in +0 -1
index 1eb69d3e93..ebf0fd262d 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_TPM2_TSS
 	bool "tpm2-tss"
-	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_LIBURIPARSER
 	help
 	  OSS implementation of the Trusted Computing Group's (TCG) TPM2
Signature · 1 line
2.14.3
author
#1 lore raw

PATCH 2/5 tmp2-tss: bump to version 1.4.0

Improved compliance to the last public review spec and some bug fixes.

Signed-off-by Carlos Santos <[email protected]>
---
 package/tpm2-tss/tpm2-tss.hash | 2 +-
 package/tpm2-tss/tpm2-tss.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/tpm2-tss/tpm2-tss.hash +1 -1
index df1c6d8b58..67c5a85842 100644
@@ -1,3 +1,3 @@
 # Locally computed:
-sha256 c7d627de50394e9a02593edb1ce74e1bbac17831be726c54f689507f0c41a78a  tpm2-tss-1.3.0.tar.gz
+sha256 cf8784cc536be16e6fba47f77033e093a6aeaed8420877ac9f42f77fb7b09031  tpm2-tss-1.4.0.tar.gz
 sha256 18c1bf4b1ba1fb2c4ffa7398c234d83c0d55475298e470ae1e5e3a8a8bd2e448  LICENSE
package/tpm2-tss/tpm2-tss.mk +1 -1
index 709602860f..f5169a2770 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-TPM2_TSS_VERSION = 1.3.0
+TPM2_TSS_VERSION = 1.4.0
 TPM2_TSS_SITE = https://github.com/tpm2-software/tpm2-tss/releases/download/$(TPM2_TSS_VERSION)
 TPM2_TSS_LICENSE = BSD-2-Clause
 TPM2_TSS_LICENSE_FILES = LICENSE
Signature · 1 line
2.14.3
#2 lore raw

PATCH 2/5 tmp2-tss: bump to version 1.4.0

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

Improved compliance to the last public review spec and some bug fixes.

Signed-off-by Carlos Santos <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/5 tmp2-tss: bump to version 1.4.0

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

"Peter" == Peter Korsgaard <[email protected]> writes:

"Carlos" == Carlos Santos <[email protected]> writes:

Improved compliance to the last public review spec and some bug fixes.

Signed-off-by Carlos Santos <[email protected]>

Committed, thanks.

It looks like this now contains some C++ code. Care to send a patch fixing the dependencies?

http://autobuild.buildroot.net/results/799/79963f81da0a250b04b105c2a73c0221e89c4c17/build-end.log

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 2/5 tmp2-tss: bump to version 1.4.0

Quoted 12 lines

From: "Peter Korsgaard" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "buildroot" <[email protected]>
Sent: Tuesday, March 20, 2018 3:23:27 AM
Subject: Re: [PATCH 2/5] tmp2-tss: bump to version 1.4.0

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

"Peter" == Peter Korsgaard <[email protected]> writes:

"Carlos" == Carlos Santos <[email protected]> writes:

Improved compliance to the last public review spec and some bug fixes.

Signed-off-by Carlos Santos <[email protected]>
Quoted 6 lines
Quoted 1 line

Committed, thanks.

It looks like this now contains some C++ code. Care to send a patch fixing the dependencies?

http://autobuild.buildroot.net/results/799/79963f81da0a250b04b105c2a73c0221e89c4c17/build-end.log

Working on this now that I'm back from vacations an traveling.

Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D
?The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.? ? Christopher Hitchens
#5 lore raw

PATCH 2/5 tmp2-tss: bump to version 1.4.0

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Committed, thanks.

It looks like this now contains some C++ code. Care to send a patch fixing the dependencies?

http://autobuild.buildroot.net/results/799/79963f81da0a250b04b105c2a73c0221e89c4c17/build-end.log

Working on this now that I'm back from vacations an traveling.

Thanks!

Signature · 1 line
Bye, Peter Korsgaard
author
#6 lore raw

PATCH 3/5 tpm2-abrmd: new package

In reply to Carlos Santos

This is a system daemon implementing the TPM2 access broker (TAB) & Resource Manager (RM) spec from the TCG. The daemon (tpm2-abrmd) is implemented using Glib and the GObject system.

Communication between the daemon and clients using the TPM is done with a combination of DBus and Unix pipes. DBus is used for discovery, session management and the 'cancel', 'setLocality', and 'getPollHandles' API calls (mostly these aren't yet implemented). Pipes are used to send and receive TPM commands and responses (respectively) between client and server.

The daemon owns the com.intel.tss2.Tabrmd name on dbus. It can be configured to connect to either the system or the session bus.

The package also provides a client library for interacting with the daemon via TPM Command Transmission Interface (TCTI). It is intended for use with the SAPI library (libsapi) like any other TCTI.

Signed-off-by Carlos Santos <[email protected]>
---
 package/Config.in                         |  1 +
 package/tpm2-abrmd/Config.in              | 25 +++++++++++
 package/tpm2-abrmd/S30devtpmperms         | 37 ++++++++++++++++
 package/tpm2-abrmd/S80tpm2-abrmd          | 74 +++++++++++++++++++++++++++++++
 package/tpm2-abrmd/etc.default.tpm2-abrmd |  1 +
 package/tpm2-abrmd/tpm2-abrmd.hash        |  3 ++
 package/tpm2-abrmd/tpm2-abrmd.mk          | 36 +++++++++++++++
 7 files changed, 177 insertions(+)
 create mode 100644 package/tpm2-abrmd/Config.in
 create mode 100755 package/tpm2-abrmd/S30devtpmperms
 create mode 100755 package/tpm2-abrmd/S80tpm2-abrmd
 create mode 100644 package/tpm2-abrmd/etc.default.tpm2-abrmd
 create mode 100644 package/tpm2-abrmd/tpm2-abrmd.hash
 create mode 100644 package/tpm2-abrmd/tpm2-abrmd.mk
package/Config.in +1 -0
index 449ffcc47b..af94c0ad91 100644
@@ -2012,6 +2012,7 @@ menu "System tools"
 	source "package/sysvinit/Config.in"
 	source "package/tar/Config.in"
 	source "package/tpm-tools/Config.in"
+	source "package/tpm2-abrmd/Config.in"
 	source "package/unscd/Config.in"
 	source "package/util-linux/Config.in"
 	source "package/xen/Config.in"
package/tpm2-abrmd/Config.in new file +25 -0
new file mode 100644
index 0000000000..31c5ae7d6b
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_TPM2_ABRMD
+	bool "tpm2-abrmd"
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus, libglib2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_TPM2_TSS
+	help
+	  A system daemon implementing the TPM2 access broker (TAB) &
+	  Resource Manager (RM) spec from the TCG. It should be started
+	  during the OS boot process. Communication between the daemon
+	  and clients using the TPM is done with a combination of DBus
+	  and Unix pipes.
+
+	  The package also provides a client library for interacting
+	  with the daemon via TPM Command Transmission Interface (TCTI).
+	  It is intended for use with the SAPI library (libsapi) like
+	  any other TCTI.
+
+	  https://github.com/tpm2-software/tpm2-abrmd
+
+comment "tpm2-abrmd needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/tpm2-abrmd/S30devtpmperms new file +37 -0
new file mode 100755
index 0000000000..5d9c42d182
@@ -0,0 +1,37 @@
+#!/bin/sh
+#
+# Set the permissions of /dev/tpm[0-9]*
+#
+
+check_device() {
+	ls -1 /dev/tpm[0-9]* > /dev/null 2>&1 || {
+		echo "device driver not loaded, skipping."
+		exit 0
+	}
+}
+
+start() {
+	printf "Setting the ownership and permissions of /dev/tpm: "
+	check_device
+	chown tss:tss /dev/tpm[0-9]* && chmod 600 /dev/tpm* \
+	&& echo "OK" || echo "FAIL"
+}
+
+stop() {
+	printf "Restoring the ownership and permissions of /dev/tpm: "
+	check_device
+	chown root:root /dev/tpm[0-9]* && chmod 600 /dev/tpm \
+	&& echo "OK" || echo "FAIL"
+}
+
+case "$1" in
+  start|restart|reload)
+      start
+	;;
+  stop)
+      stop
+	;;
+  *)
+	echo "Usage: $0 {start|stop|restart}"
+	exit 1
+esac
package/tpm2-abrmd/S80tpm2-abrmd new file +74 -0

74 lines not on this page · raw message

package/tpm2-abrmd/etc.default.tpm2-abrmd new file +1 -0
new file mode 100644
index 0000000000..987978a665
@@ -0,0 +1 @@
+DAEMON_OPTS="--tcti=device --logger=syslog --max-connections=20 --max-transient-objects=20 --fail-on-loaded-trans"
package/tpm2-abrmd/tpm2-abrmd.hash new file +3 -0
new file mode 100644
index 0000000000..6af991d469
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 e32e19de93b539374a485d9df7fe9415ce147ec03c8d9ba6593e50f7a67a7a51  tpm2-abrmd-1.3.0.tar.gz
+sha256 18c1bf4b1ba1fb2c4ffa7398c234d83c0d55475298e470ae1e5e3a8a8bd2e448  LICENSE
package/tpm2-abrmd/tpm2-abrmd.mk new file +36 -0
new file mode 100644
index 0000000000..4964affbf3
@@ -0,0 +1,36 @@
+################################################################################
+#
+# tpm2-abrmd
+#
+################################################################################
+
+TPM2_ABRMD_VERSION = 1.3.0
+TPM2_ABRMD_SITE = https://github.com/tpm2-software/tpm2-abrmd/releases/download/$(TPM2_ABRMD_VERSION)
+TPM2_ABRMD_LICENSE = BSD-2-Clause
+TPM2_ABRMD_LICENSE_FILES = LICENSE
+TPM2_ABRMD_INSTALL_STAGING = YES
+TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf
+
+TPM2_ABRMD_CONF_OPTS += \
+	--with-systemdsystemunitdir=$(if $(BR2_INIT_SYSTEMD),/usr/lib/systemd/system,no) \
+	--with-udevrulesdir=$(if $(BR2_PACKAGE_HAS_UDEV),/usr/lib/udev/rules.d,no)
+
+define TPM2_ABRMD_INSTALL_INIT_SYSTEMD
+	$(TARGET_MAKE_ENV) $(MAKE1) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		install-systemdpresetDATA install-systemdsystemunitDATA
+endef
+
+# Without udev we need an init script to set the ownership of /dev/tpm[0-9]*
+define TPM2_ABRMD_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 -t $(TARGET_DIR)/etc/init.d \
+		$(if $(BR2_PACKAGE_HAS_UDEV),,$(TPM2_ABRMD_PKGDIR)/S30devtpmperms) \
+		$(TPM2_ABRMD_PKGDIR)/S80tpm2-abrmd
+	$(INSTALL) -D -m 0644 $(TPM2_ABRMD_PKGDIR)/etc.default.tpm2-abrmd \
+		$(TARGET_DIR)/etc/default/tpm2-abrmd
+endef
+
+define TPM2_ABRMD_USERS
+	tss -1 tss -1 * - - - TPM2 Access Broker & Resource Management daemon
+endef
+
+$(eval $(autotools-package))
Signature · 1 line
2.14.3
#7 lore raw

PATCH 3/5 tpm2-abrmd: new package

Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

This is a system daemon implementing the TPM2 access broker (TAB) & Resource Manager (RM) spec from the TCG. The daemon (tpm2-abrmd) is implemented using Glib and the GObject system.

Communication between the daemon and clients using the TPM is done with a combination of DBus and Unix pipes. DBus is used for discovery, session management and the 'cancel', 'setLocality', and 'getPollHandles' API calls (mostly these aren't yet implemented). Pipes are used to send and receive TPM commands and responses (respectively) between client and server.

The daemon owns the com.intel.tss2.Tabrmd name on dbus. It can be configured to connect to either the system or the session bus.

The package also provides a client library for interacting with the daemon via TPM Command Transmission Interface (TCTI). It is intended for use with the SAPI library (libsapi) like any other TCTI.

Quoted 7 lines
Signed-off-by Carlos Santos <[email protected]>
---
 package/Config.in                         |  1 +
 package/tpm2-abrmd/Config.in              | 25 +++++++++++
 package/tpm2-abrmd/S30devtpmperms         | 37 ++++++++++++++++
 package/tpm2-abrmd/S80tpm2-abrmd          | 74 +++++++++++++++++++++++++++++++
 package/tpm2-abrmd/etc.default.tpm2-abrmd |  1 +

I think this is a bit too complicated / wordy. When there are sensible defaults we add those to the init script and just allow an /etc/default/<pkg> to override it for special setups, so I've dropped the etc.default.tpm2-abrmd.

The same for S30devtpmperms - I have simply added:

chown tss:tss /dev/tpm[0-9]* && chmod 600 /dev/tpm*

To check_device() in S80tpm2-abrmd and dropped S30devtpmperms.

Committed with these changes, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#8 lore raw

PATCH 4/5 tpm2-tools: new package

In reply to Carlos Santos

TPM (Trusted Platform Module) 2.0 CLI tools based on system API of TPM2-TSS. These tools can be used to manage keys, perform encryption/decryption/signing/etc crypto operations, and manage non-volatile storage through a TPM2.0 HW implementation.

Signed-off-by Carlos Santos <[email protected]>
---
 package/Config.in                                  |  1 +
 .../tpm2-tools/0001-Fix-build-with-LibreSSL.patch  | 64 ++++++++++++++++++++++
 package/tpm2-tools/Config.in                       | 16 ++++++
 package/tpm2-tools/tpm2-tools.hash                 |  3 +
 package/tpm2-tools/tpm2-tools.mk                   | 13 +++++
 5 files changed, 97 insertions(+)
 create mode 100644 package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch
 create mode 100644 package/tpm2-tools/Config.in
 create mode 100644 package/tpm2-tools/tpm2-tools.hash
 create mode 100644 package/tpm2-tools/tpm2-tools.mk
package/Config.in +1 -0
index af94c0ad91..58dfd6306d 100644
@@ -2013,6 +2013,7 @@ menu "System tools"
 	source "package/tar/Config.in"
 	source "package/tpm-tools/Config.in"
 	source "package/tpm2-abrmd/Config.in"
+	source "package/tpm2-tools/Config.in"
 	source "package/unscd/Config.in"
 	source "package/util-linux/Config.in"
 	source "package/xen/Config.in"
package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch new file +64 -0

64 lines not on this page · raw message

package/tpm2-tools/Config.in new file +16 -0
new file mode 100644
index 0000000000..6429b24531
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_TPM2_TOOLS
+	bool "tpm2-tools"
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_TPM2_ABRMD # run-time
+	select BR2_PACKAGE_TPM2_TSS
+	help
+	  TPM (Trusted Platform Module) 2.0 CLI tools based on system
+	  API of TPM2-TSS. These tools can be used to manage keys,
+	  perform encryption/decryption/signing/etc crypto operations,
+	  and manage non-volatile storage through a TPM2.0 HW
+	  implementation.
+
+	  https://github.com/tpm2-software/tpm2-tools
package/tpm2-tools/tpm2-tools.hash new file +3 -0
new file mode 100644
index 0000000000..e33b3e5945
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 c990c0656165afef0fad61e1852a9a189a4b93b43d2a684b151a5dc0b3c6249d  tpm2-tools-3.0.3.tar.gz
+sha256 3d6b149c8b042bd5f3db678d587fbe55230d071ca084bd38dcae451679c6dd45  LICENSE
package/tpm2-tools/tpm2-tools.mk new file +13 -0
new file mode 100644
index 0000000000..0697900d2d
@@ -0,0 +1,13 @@
+################################################################################
+#
+# tpm2-tools
+#
+################################################################################
+
+TPM2_TOOLS_VERSION = 3.0.3
+TPM2_TOOLS_SITE = https://github.com/tpm2-software/tpm2-tools/releases/download/$(TPM2_TOOLS_VERSION)
+TPM2_TOOLS_LICENSE = BSD-2-Clause
+TPM2_TOOLS_LICENSE_FILES = LICENSE
+TPM2_TOOLS_DEPENDENCIES = dbus libcurl libglib2 openssl tpm2-tss host-pkgconf
+
+$(eval $(autotools-package))
Signature · 1 line
2.14.3
#9 lore raw

PATCH 4/5 tpm2-tools: new package

Quoted 44 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

TPM (Trusted Platform Module) 2.0 CLI tools based on system API of TPM2-TSS. These tools can be used to manage keys, perform encryption/decryption/signing/etc crypto operations, and manage non-volatile storage through a TPM2.0 HW implementation.

Signed-off-by Carlos Santos <[email protected]>
---
 package/Config.in                                  |  1 +
 .../tpm2-tools/0001-Fix-build-with-LibreSSL.patch  | 64 ++++++++++++++++++++++
 package/tpm2-tools/Config.in                       | 16 ++++++
 package/tpm2-tools/tpm2-tools.hash                 |  3 +
 package/tpm2-tools/tpm2-tools.mk                   | 13 +++++
 5 files changed, 97 insertions(+)
 create mode 100644 package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch
 create mode 100644 package/tpm2-tools/Config.in
 create mode 100644 package/tpm2-tools/tpm2-tools.hash
 create mode 100644 package/tpm2-tools/tpm2-tools.mk
package/Config.in +1 -0
index af94c0ad91..58dfd6306d 100644
@@ -2013,6 +2013,7 @@ menu "System tools"
 	source "package/tar/Config.in"
 	source "package/tpm-tools/Config.in"
 	source "package/tpm2-abrmd/Config.in"
+	source "package/tpm2-tools/Config.in"
 	source "package/unscd/Config.in"
 	source "package/util-linux/Config.in"
 	source "package/xen/Config.in"
package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch new file +6 -0
new file mode 100644
index 0000000000..0fdd2dc4dd
@@ -0,0 +1,64 @@
+From 7f8d9359dcf9edbb13bb447f70234397afa4fb05 Mon Sep 17 00:00:00 2001
+From: Carlos Santos <[email protected]>
+Date: Tue, 30 Jan 2018 11:21:14 -0200
+Subject: [PATCH] Fix build with LibreSSL
+
+OPENSSL_VERSION_NUMBER is used to test the version of OpenSSL but this

package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch line 16

Quoted 10 lines
package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch new file +10 -0
+test alone breaks the build with LibreSSL due to implicit declarations
+of functions 'RSA_set0_key' and 'HMAC_CTX_free'.
+
+Test if OpenSSL < 1.1.0 or LIBRESSL_VERSION_NUMBER is defined, instead.
+
+Signed-off-by: Carlos Santos <[email protected]>
+---
+ lib/conversion.c | 2 +-
+ lib/tpm_kdfa.c   | 6 +++---
+ 2 files changed, 4 insertions(+), 4 deletions(-)

It would have been good to mention that this patch is now upstream:

https://github.com/tpm2-software/tpm2-tools/commit/0899f5b7acfb0ef1b71518f7b94cf84776018edd

I see that the upstream commit also patches a number of files under tools/ - Why did you drop those here?

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#10 lore raw

PATCH 4/5 tpm2-tools: new package

Quoted 64 lines

From: "Peter Korsgaard" <[email protected]>
To: "Carlos Santos" <[email protected]>
Cc: "buildroot" <[email protected]>
Sent: Sunday, March 18, 2018 7:24:17 PM
Subject: Re: [PATCH 4/5] tpm2-tools: new package

Quoted 45 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

TPM (Trusted Platform Module) 2.0 CLI tools based on system API of TPM2-TSS. These tools can be used to manage keys, perform encryption/decryption/signing/etc crypto operations, and manage non-volatile storage through a TPM2.0 HW implementation.

Signed-off-by Carlos Santos <[email protected]>
---
 package/Config.in                                  |  1 +
 .../tpm2-tools/0001-Fix-build-with-LibreSSL.patch  | 64 ++++++++++++++++++++++
 package/tpm2-tools/Config.in                       | 16 ++++++
 package/tpm2-tools/tpm2-tools.hash                 |  3 +
 package/tpm2-tools/tpm2-tools.mk                   | 13 +++++
 5 files changed, 97 insertions(+)
 create mode 100644 package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch
 create mode 100644 package/tpm2-tools/Config.in
 create mode 100644 package/tpm2-tools/tpm2-tools.hash
 create mode 100644 package/tpm2-tools/tpm2-tools.mk
package/Config.in +1 -0
index af94c0ad91..58dfd6306d 100644
@@ -2013,6 +2013,7 @@ menu "System tools"
 	source "package/tar/Config.in"
 	source "package/tpm-tools/Config.in"
 	source "package/tpm2-abrmd/Config.in"
+	source "package/tpm2-tools/Config.in"
 	source "package/unscd/Config.in"
 	source "package/util-linux/Config.in"
 	source "package/xen/Config.in"
package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch new file +6 -0
new file mode 100644
index 0000000000..0fdd2dc4dd
@@ -0,0 +1,64 @@
+From 7f8d9359dcf9edbb13bb447f70234397afa4fb05 Mon Sep 17 00:00:00 2001
+From: Carlos Santos <[email protected]>
+Date: Tue, 30 Jan 2018 11:21:14 -0200
+Subject: [PATCH] Fix build with LibreSSL
+
+OPENSSL_VERSION_NUMBER is used to test the version of OpenSSL but this

package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch line 16

Quoted 10 lines
package/tpm2-tools/0001-Fix-build-with-LibreSSL.patch new file +10 -0
+test alone breaks the build with LibreSSL due to implicit declarations
+of functions 'RSA_set0_key' and 'HMAC_CTX_free'.
+
+Test if OpenSSL < 1.1.0 or LIBRESSL_VERSION_NUMBER is defined, instead.
+
+Signed-off-by: Carlos Santos <[email protected]>
+---
+ lib/conversion.c | 2 +-
+ lib/tpm_kdfa.c   | 6 +++---
+ 2 files changed, 4 insertions(+), 4 deletions(-)

It would have been good to mention that this patch is now upstream:

Quoted 4 lines

https://github.com/tpm2-software/tpm2-tools/commit/0899f5b7acfb0ef1b71518f7b94cf84776018edd

I see that the upstream commit also patches a number of files under tools/ - Why did you drop those here?

This patch is for version 3.0.3. The patches submitted upstream were for the master branch on which those additional files exist.

Quoted 1 line

Committed, thanks.

Thanks

[Sorry for the late answer. I was on vacations and on travel until
last Monday.]

Signature · 4 lines
Carlos Santos (Casantos) - DATACOM, P&D
?The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.? ? Christopher Hitchens
author
#11 lore raw

PATCH 5/5 DEVELOPERS: add myself for tpm2-{abrmd, tools, tss}.

In reply to Carlos Santos
Signed-off-by Carlos Santos <[email protected]>
---
 DEVELOPERS | 3 +++
 1 file changed, 3 insertions(+)
DEVELOPERS +3 -0
index 3df820e712..1faefc45fc 100644
@@ -394,6 +394,9 @@ F:	package/libpam-radius-auth/
 F:	package/libpam-tacplus/
 F:	package/perl-file-util/
 F:	package/util-linux/
+F:	package/tpm2-abrmd/
+F:	package/tpm2-tools/
+F:	package/tpm2-tss/
 
 N:	Carsten Schoenert <[email protected]>
 F:	package/dvbsnoop/
Signature · 1 line
2.14.3
#13 lore raw

PATCH 1/5 tmp2-tss: remove architecture restriction

In reply to Carlos Santos
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

Followingig a suggestion from Peter Korsgaard, remove the restriction to x86 and x86_64. It is preferable to expose the package unless there is a build time dependency on an architecture or the package is specific to a certain SoC or board.

Signed-off-by Carlos Santos <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard