Skip to contentSkip to conversation

85xx: properly document MPC85xx_PORDEVSR2_SEC_CFG

PATCH New Timur Tabi 2 participants 2 messages Oct 20, 2008 – Oct 21, 2008

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH v2 1/1 85xx: properly document MPC85xx_PORDEVSR2_SEC_CFG

Commit f7d190b1 corrected the value of MPC85xx_PORDEVSR2_SEC_CFG, but forgot to add a comment that the correct value disagrees with the 8544 reference manual. The changelog for that commit is also wrong, as it says "bit 28" when it should be "bit 24".

Signed-off-by Timur Tabi <[email protected]>
---
 include/asm-ppc/immap_85xx.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/asm-ppc/immap_85xx.h +1 -0
index 6c81c39..d717bd8 100644
@@ -1579,6 +1579,7 @@ typedef struct ccsr_gur {
 #define MPC85xx_PORDEVSR_RIO_DEV_ID	0x00000007
 	uint	pordbgmsr;	/* 0xe0010 - POR debug mode status register */
 	uint	pordevsr2;	/* 0xe0014 - POR I/O device status regsiter 2 */
+/* The 8544 RM says this is bit 26, but it's really bit 24 */
 #define MPC85xx_PORDEVSR2_SEC_CFG	0x00000080
 	char	res1[8];
 	uint	gpporcr;	/* 0xe0020 - General-purpose POR configuration register */
Signature · 1 line
1.5.5
Applied
#1 lore raw

PATCH v2 1/1 85xx: properly document MPC85xx_PORDEVSR2_SEC_CFG

Dear Timur Tabi,

Quoted 9 lines · In message <[email protected]> you wrote:

Commit f7d190b1 corrected the value of MPC85xx_PORDEVSR2_SEC_CFG, but forgot to add a comment that the correct value disagrees with the 8544 reference manual. The changelog for that commit is also wrong, as it says "bit 28" when it should be "bit 24".

Signed-off-by Timur Tabi <[email protected]>
---
 include/asm-ppc/immap_85xx.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When the ax entered the forest, the trees said, "The handle is one of
us!"                                               -- Turkish proverb