Skip to contentSkip to conversation

trace: create tracers menu

PATCH Applied Peter Zijlstra 4 participants 8 messages Oct 21, 2008 – Oct 22, 2008 Tracing

lore
Share & tools
lore

Peter Zijlstra

author
#0 lore raw

PATCH 1/1 trace: create tracers menu

Subject: trace: create tracers menu
From: Peter Zijlstra <[email protected]>
Date: Tue Oct 21 16:26:36 CEST 2008

We seem to have plenty tracers, lets create a menu and not clutter the already cluttered debug menu more.

Signed-off-by Peter Zijlstra <[email protected]>
---
 kernel/trace/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)
kernel/trace/Kconfig +4 -0
Index: linux-2.6/kernel/trace/Kconfig
===================================================================
@@ -29,6 +29,8 @@ config TRACING
 	select STACKTRACE
 	select TRACEPOINTS
 
+menu "Tracers"
+
 config FUNCTION_TRACER
 	bool "Kernel Function Tracer"
 	depends on HAVE_FUNCTION_TRACER

@@ -191,3 +193,5 @@ config FTRACE_STARTUP_TEST
 	  a series of tests are made to verify that the tracer is
 	  functioning properly. It will do tests on all the configured
 	  tracers of ftrace.
+
+endmenu
#1 lore raw

2008/10/21 Peter Zijlstra <[email protected]>:

Quoted 26 lines

Subject: trace: create tracers menu
From: Peter Zijlstra <[email protected]>
Date: Tue Oct 21 16:26:36 CEST 2008

We seem to have plenty tracers, lets create a menu and not clutter the already cluttered debug menu more.

Signed-off-by Peter Zijlstra <[email protected]>
---
 kernel/trace/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6/kernel/trace/Kconfig
===================================================================

kernel/trace/Kconfig +2 -0
@@ -29,6 +29,8 @@ config TRACING
       select STACKTRACE
       select TRACEPOINTS
 
+menu "Tracers"
+
 config FUNCTION_TRACER
       bool "Kernel Function Tracer"
       depends on HAVE_FUNCTION_TRACER

kernel/trace/Kconfig config FTRACE_STARTUP_TEST · line 197

Quoted 5 lines
kernel/trace/Kconfig +2 -0
@@ -191,3 +193,5 @@ config FTRACE_STARTUP_TEST
         a series of tests are made to verify that the tracer is
         functioning properly. It will do tests on all the configured
         tracers of ftrace.
+
+endmenu

Good Idea :)

#2 lore raw

2008/10/21 Frédéric Weisbecker <[email protected]>:

Quoted 7 lines

2008/10/21 Peter Zijlstra <[email protected]>:

Quoted 6 lines

Subject: trace: create tracers menu
From: Peter Zijlstra <[email protected]>
Date: Tue Oct 21 16:26:36 CEST 2008

We seem to have plenty tracers, lets create a menu and not clutter the already cluttered debug menu more.

But...you just included the function tracer inside?

author
#3 lore raw
Quoted 10 lines · Frédéric Weisbecker

2008/10/21 Frédéric Weisbecker <[email protected]>:

Quoted 7 lines

2008/10/21 Peter Zijlstra <[email protected]>:

Quoted 6 lines

Subject: trace: create tracers menu
From: Peter Zijlstra <[email protected]>
Date: Tue Oct 21 16:26:36 CEST 2008

We seem to have plenty tracers, lets create a menu and not clutter the already cluttered debug menu more.

But...you just included the function tracer inside?

Problem being? That's a tracer too, right? And it doesn't seem required by the other tracers (except the max stack tracer).

#4 lore raw

2008/10/21 Peter Zijlstra <[email protected]>:

Quoted 2 lines

Problem being? That's a tracer too, right? And it doesn't seem required by the other tracers (except the max stack tracer).

Sorry I didn't want to write "just" but "only". I misread the patch and I believed
there only was the function tracer inside.

maintainer
#5 lore raw
In reply to Frédéric Weisbecker
Quoted 10 lines · Fr?d?ric Weisbecker

2008/10/21 Fr?d?ric Weisbecker <[email protected]>:

Quoted 7 lines

2008/10/21 Peter Zijlstra <[email protected]>:

Quoted 6 lines

Subject: trace: create tracers menu
From: Peter Zijlstra <[email protected]>
Date: Tue Oct 21 16:26:36 CEST 2008

We seem to have plenty tracers, lets create a menu and not clutter the already cluttered debug menu more.

But...you just included the function tracer inside?

Sure, why not? The function tracer is its own tracer itself.

-- Steve

Applied
#7 lore raw
Quoted 6 lines · Steven Rostedt
Quoted 4 lines · Peter Zijlstra

Subject: trace: create tracers menu
From: Peter Zijlstra <[email protected]>
Date: Tue Oct 21 16:26:36 CEST 2008

Quoted 6 lines
Quoted 4 lines

We seem to have plenty tracers, lets create a menu and not clutter the already cluttered debug menu more.

Signed-off-by Peter Zijlstra <[email protected]>
Acked-by Steven Rostedt <[email protected]>

applied to tip/tracing/urgent, thanks!

Ingo