Skip to contentSkip to conversation

byteorder: remove direct includes of linux/byteorder/swab[b].h

PATCH In review Harvey Harrison 3 participants 4 messages Oct 20, 2008 – Oct 22, 2008 Linux-next tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 byteorder: remove direct includes of linux/byteorder/swab[b].h

A consolidated implementation will provide this generically through asm/byteorder, remove direct includes to avoid breakage when the changeover to the new implementation occurs.

---
Andrew, this hunk seems to have been lost when you sent it to Linus, it's possible you applied this on top of the -next tree where this file has moved, but the tests tree hasn't been pulled yet.

The rest of the patch went into mainline as 1d8cca44b6a244b7e378546d719041819049a0f9

I believe it was acked-by Paul, but CC'd to be sure.

 kernel/rcutorture.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/rcutorture.c +1 -1
index 90b5b12..85cb905 100644
@@ -42,10 +42,10 @@
 #include <linux/freezer.h>
 #include <linux/cpu.h>
 #include <linux/delay.h>
-#include <linux/byteorder/swabb.h>
 #include <linux/stat.h>
 #include <linux/srcu.h>
 #include <linux/slab.h>
+#include <asm/byteorder.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Paul E. McKenney <[email protected]> and "
Signature · 1 line
1.6.0.2
#1 lore raw
Quoted 4 lines · On Mon, 20 Oct 2008 10:23:38 -0700 Harvey Harrison <[email protected]>…

A consolidated implementation will provide this generically through asm/byteorder, remove direct includes to avoid breakage when the changeover to the new implementation occurs.

Quoted 8 lines

---
Andrew, this hunk seems to have been lost when you sent it to Linus, it's possible you applied this on top of the -next tree where this file has moved, but the tests tree hasn't been pulled yet.

The rest of the patch went into mainline as 1d8cca44b6a244b7e378546d719041819049a0f9

Grump. It happens sometimes. People putting stuff into linux-next and then not merging it into the next kernel.

Quoted 9 lines
 kernel/rcutorture.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/rcutorture.c +0 -0
index 90b5b12..85cb905 100644

kernel/rcutorture.c line 48

Quoted 8 lines
kernel/rcutorture.c +1 -1
@@ -42,10 +42,10 @@
 #include <linux/freezer.h>
 #include <linux/cpu.h>
 #include <linux/delay.h>
-#include <linux/byteorder/swabb.h>
 #include <linux/stat.h>
 #include <linux/srcu.h>
 #include <linux/slab.h>
+#include <asm/byteorder.h>

Should this be linux/byteorder.h? (Which weirdly doesn't include asm/byteorder.h).

#2 lore raw
Quoted 13 lines · Andrew Morton
Quoted 10 lines · On Mon, 20 Oct 2008 10:23:38 -0700 Harvey Harrison <[email protected]>…

A consolidated implementation will provide this generically through asm/byteorder, remove direct includes to avoid breakage when the changeover to the new implementation occurs.

---
Andrew, this hunk seems to have been lost when you sent it to Linus, it's possible you applied this on top of the -next tree where this file has moved, but the tests tree hasn't been pulled yet.

Quoted 8 lines
Quoted 2 lines

The rest of the patch went into mainline as 1d8cca44b6a244b7e378546d719041819049a0f9

Grump. It happens sometimes. People putting stuff into linux-next and then not merging it into the next kernel.

Should this be linux/byteorder.h? (Which weirdly doesn't include asm/byteorder.h).

As the implementations all used to live in asm/byteorder.h before consolidating, it needs to be asm until all arches convert. At that time we can do the flip and let linux/ be directly includable.

Harvey

#3 lore raw
In reply to Andrew Morton
Quoted 10 lines · On Tue, 21 Oct 2008 13:15:34 -0700 Andrew Morton <[email protected]>…
Quoted 7 lines

Andrew, this hunk seems to have been lost when you sent it to Linus, it's possible you applied this on top of the -next tree where this file has moved, but the tests tree hasn't been pulled yet.

The rest of the patch went into mainline as 1d8cca44b6a244b7e378546d719041819049a0f9

Grump. It happens sometimes. People putting stuff into linux-next and then not merging it into the next kernel.

The "tests" tree has been requested to be pulled twice (or so) with no response apparently, so I have now dropped it from the -next tree until someone decides if we want to integrate it at all.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/