edac/cell: enable polling mode

PATCH In review Jens Osterkamp 2 participants 2 messages Oct 21, 2008 EDAC-core

lore

Share & tools

lore

Jens Osterkamp

author

2008-10-21 14:08 UTC #0 lore raw

PATCH 1/1 edac/cell: enable polling mode

From: Benjamin Herrenschmidt <[email protected]>

The edac driver on cell turned out to be not enabled because of a missing op_state. This patch introduces it. Verified to work on top of Bens next branch.

Signed-off-by Arnd Bergmann <[email protected]>

Signed-off-by Jens Osterkamp <[email protected]>

---

Ben, can you please confirm this is the patch you wanted to send upstream ?

drivers/edac/cell_edac.c +3 -0

Index: linux-2.6/drivers/edac/cell_edac.c
===================================================================
@@ -9,6 +9,7 @@
  */
 #undef DEBUG
 
+#include <linux/edac.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>

@@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
 	if (regs == NULL)
 		return -ENODEV;
 
+	edac_op_state = EDAC_OPSTATE_POLL;
+
 	/* Get channel population */
 	reg = in_be64(&regs->mic_mnt_cfg);
 	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);

---

Gruß,

Jens

IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Benjamin Herrenschmidt

Acked-by on v1 1/1

2008-10-21 20:59 UTC #1 lore raw

Quoted 7 lines · Jens Osterkamp

From: Benjamin Herrenschmidt <[email protected]>
The edac driver on cell turned out to be not enabled because of a missing op_state. This patch introduces it. Verified to work on top of Bens next branch.
Signed-off-by Arnd Bergmann <[email protected]>
Signed-off-by Jens Osterkamp <[email protected]>

Acked-by Benjamin Herrenschmidt <[email protected]>

Quoted 3 lines

---
Ben, can you please confirm this is the patch you wanted to send upstream ?

Yes.

Quoted 32 lines

Index: linux-2.6/drivers/edac/cell_edac.c
===================================================================
drivers/edac/cell_edac.c +3 -1
@@ -9,6 +9,7 @@
  */
 #undef DEBUG
 
+#include <linux/edac.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
@@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
 	if (regs == NULL)
 		return -ENODEV;
 
+	edac_op_state = EDAC_OPSTATE_POLL;
+
 	/* Get channel population */
 	reg = in_be64(&regs->mic_mnt_cfg);
 	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
---
Gruß,
Jens
IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294