Skip to contentSkip to conversation

virtio_net: hook up the set-tso ethtool op

PATCH Applied Mark McLoughlin 2 participants 3 messages Oct 22, 2008 – Oct 23, 2008

Subsystems (4)
Networking Network drivers virtio core virtio net driver
lore
Share & tools
lore

Mark McLoughlin

author
#0 lore raw

PATCH 1/1 virtio_net: hook up the set-tso ethtool op

Seems like an oversight that we have set-tx-csum and set-sg hooked up, but not set-tso.

Also leads to the strange situation that if you e.g. disable tx-csum, then tso doesn't get disabled.

Signed-off-by Mark McLoughlin <[email protected]>
---
 drivers/net/virtio_net.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/virtio_net.c +1 -0
index cca6435..79b59cc 100644
@@ -612,6 +612,7 @@ static int virtnet_set_tx_csum(struct net_device *dev, u32 data)
 static struct ethtool_ops virtnet_ethtool_ops = {
 	.set_tx_csum = virtnet_set_tx_csum,
 	.set_sg = ethtool_op_set_sg,
+	.set_tso = ethtool_op_set_tso,
 };
 
 static int virtnet_probe(struct virtio_device *vdev)
Signature · 1 line
1.6.0.1
Applied
#1 lore raw
Quoted 5 lines · On Thursday 23 October 2008 02:32:26 Mark McLoughlin wrote:

Seems like an oversight that we have set-tx-csum and set-sg hooked up, but not set-tso.

Also leads to the strange situation that if you e.g. disable tx-csum, then tso doesn't get disabled.

Thanks, applied.

Rusty.

Applied
#2 lore raw
In reply to Mark McLoughlin
Quoted 5 lines · On Thursday 23 October 2008 02:32:26 Mark McLoughlin wrote:

Seems like an oversight that we have set-tx-csum and set-sg hooked up, but not set-tso.

Also leads to the strange situation that if you e.g. disable tx-csum, then tso doesn't get disabled.

Thanks, applied.

Rusty.