Skip to contentSkip to conversation

Add support for pairing a few GPS devices

PATCH In review Bastien Nocera 3 participants 3 messages Oct 23, 2008 – Nov 11, 2008 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add support for pairing a few GPS devices

Add support for hard-coded pincodes for a few GPS devices, one being mine, the other being mentioned by Ralph Loader in
https://bugzilla.redhat.com/show_bug.cgi?id=464446

Cheers

Quoted 1 line

From 91d5a9fc32f990c92fa5091c046ccbb6ed2e72e0 Mon Sep 17 00:00:00 2001

From: Bastien Nocera <[email protected]>
Date: Thu, 23 Oct 2008 22:51:30 +0100
Subject: [PATCH] Add support for pairing a few GPS devices

Add support for hard-coded pincodes for a few GPS devices, one being mine, the other being mentioned by Ralph Loader in
https://bugzilla.redhat.com/show_bug.cgi?id=464446

---
 wizard/main.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
wizard/main.c +8 -0
index 6f0b035..a20e280 100644
@@ -75,6 +75,14 @@ static gboolean pincode_callback(DBusGMethodInvocation *context,
 				target_type == BLUETOOTH_TYPE_HEADPHONE)
 		pincode = "0000";
 
+	/* Most GPS devices also use 0000 as pincode */
+	if (g_str_has_prefix(target_address, "00:0D:B5") == TRUE &&
+				(g_str_equal(target_name,
+							"TomTom Wireless GPS MkII") == TRUE ||
+				g_str_equal(target_name,
+							"GPS-GW-005") == TRUE))
+		pincode = "0000";
+
 	text = g_strdup_printf(_("Please enter the following PIN code: %s"),
 								pincode);
 	gtk_label_set_markup(GTK_LABEL(label_passkey), text);
Signature · 1 line
1.6.0.3
#2 lore raw

Hi,

Quoted 7 lines · ext Marcel Holtmann

Hi Bastien,

Quoted 3 lines

Add support for hard-coded pincodes for a few GPS devices, one being mine, the other being mentioned by Ralph Loader in
https://bugzilla.redhat.com/show_bug.cgi?id=464446

patch has been applied. Thanks.

I have never followed bluez-gnome developement and I might have some gaps in knowlegde of made decisions.

Is it really intentional not to have user specified passkey as an option? Of course there can be a list of "known pincodes" but frankly I don't believe all the codes will be there in some point. At least the list should be editable by the user?

Signature · 1 line
Ville