Skip to contentSkip to conversation

Sort devices by type in the treeviews

PATCH In review Bastien Nocera 2 participants 4 messages Oct 26, 2008 – Oct 27, 2008 Bluetooth drivers

lore
Share & tools
lore

Bastien Nocera

author
#0 lore raw

PATCH 1/1 Sort devices by type in the treeviews

Sorting by RSSI means that the devices just around in the treeview which is painfully annoying.

Quoted 1 line

From dcc41434b39493d97cd3ec36d07c8a59ae4f0211 Mon Sep 17 00:00:00 2001

From: Bastien Nocera <[email protected]>
Date: Sun, 26 Oct 2008 12:36:33 +0000
Subject: [PATCH] Sort devices by type in the treeviews

Sorting by RSSI means that the devices just around in the treeview which is painfully annoying.

---
 common/helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/helper.c +1 -1
index e53d4bc..7335b7f 100644
@@ -185,7 +185,7 @@ gchar *show_browse_dialog(void)
 	model = bluetooth_client_get_device_model(client, NULL);
 	sorted = gtk_tree_model_sort_new_with_model(model);
 	gtk_tree_sortable_set_sort_column_id(GTK_TREE_SORTABLE(sorted),
-				BLUETOOTH_COLUMN_RSSI, GTK_SORT_DESCENDING);
+				BLUETOOTH_COLUMN_TYPE, GTK_SORT_DESCENDING);
 	tree = create_tree(sorted, TRUE);
 	g_object_unref(sorted);
 	g_object_unref(model);
Signature · 1 line
1.6.0.3
maintainer
#1 lore raw

Hi Bastien,

Quoted 2 lines

Sorting by RSSI means that the devices just around in the treeview which is painfully annoying.

we want to sort by RSSI to list devices in range first. However we should extend the sorting to always list already known or paired devices first. This should stop them from moving around.

If it stil jumps too much for you, then we might just improve the sorting mechanism to be a little bit more resistance for jumping around, but sorting by type gives us no advantage.

Regards

Marcel

author
#2 lore raw
Quoted 5 lines · Marcel Holtmann

Hi Bastien,

Quoted 2 lines

Sorting by RSSI means that the devices just around in the treeview which is painfully annoying.

Quoted 7 lines

we want to sort by RSSI to list devices in range first. However we should extend the sorting to always list already known or paired devices first. This should stop them from moving around.

If it stil jumps too much for you, then we might just improve the sorting mechanism to be a little bit more resistance for jumping around, but sorting by type gives us no advantage.

It certainly jumps around far too much. It flickers tens of times a second, switching between a phone and the Mac mini just next to it...

maintainer
#3 lore raw

Hi Bastien,

Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Sorting by RSSI means that the devices just around in the treeview which is painfully annoying.

we want to sort by RSSI to list devices in range first. However we should extend the sorting to always list already known or paired devices first. This should stop them from moving around.

Quoted 6 lines
Quoted 3 lines

If it stil jumps too much for you, then we might just improve the sorting mechanism to be a little bit more resistance for jumping around, but sorting by type gives us no advantage.

It certainly jumps around far too much. It flickers tens of times a second, switching between a phone and the Mac mini just next to it...

then we just need to be smart about it. Meaning we only switch positions if the RSSI value is a big difference. So that close devices don't jump that much.

Regards

Marcel