Skip to contentSkip to conversation

sh: ap325rxa: Moveed ap325rxa board in board/renesas

PATCH New Nobuhiro Iwamatsu 3 participants 5 messages Oct 28, 2008 – Oct 30, 2008

Subsystems (2)
Kbuild Arm/actions semi architecture
lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/7 sh: ap325rxa: Moveed ap325rxa board in board/renesas

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 Makefile                               |    2 +-
 board/ap325rxa/Makefile                |   51 -------
 board/ap325rxa/ap325rxa.c              |  162 ---------------------
 board/ap325rxa/config.mk               |   26 ----
 board/ap325rxa/cpld-ap325rxa.c         |  206 ---------------------------
 board/ap325rxa/lowlevel_init.S         |  243 --------------------------------
 board/ap325rxa/u-boot.lds              |  105 --------------
 board/renesas/ap325rxa/Makefile        |   51 +++++++
 board/renesas/ap325rxa/ap325rxa.c      |  162 +++++++++++++++++++++
 board/renesas/ap325rxa/config.mk       |   26 ++++
 board/renesas/ap325rxa/cpld-ap325rxa.c |  206 +++++++++++++++++++++++++++
 board/renesas/ap325rxa/lowlevel_init.S |  243 ++++++++++++++++++++++++++++++++
 board/renesas/ap325rxa/u-boot.lds      |  105 ++++++++++++++
 13 files changed, 794 insertions(+), 794 deletions(-)
 delete mode 100644 board/ap325rxa/Makefile
 delete mode 100644 board/ap325rxa/ap325rxa.c
 delete mode 100644 board/ap325rxa/config.mk
 delete mode 100644 board/ap325rxa/cpld-ap325rxa.c
 delete mode 100644 board/ap325rxa/lowlevel_init.S
 delete mode 100644 board/ap325rxa/u-boot.lds
 create mode 100644 board/renesas/ap325rxa/Makefile
 create mode 100644 board/renesas/ap325rxa/ap325rxa.c
 create mode 100644 board/renesas/ap325rxa/config.mk
 create mode 100644 board/renesas/ap325rxa/cpld-ap325rxa.c
 create mode 100644 board/renesas/ap325rxa/lowlevel_init.S
 create mode 100644 board/renesas/ap325rxa/u-boot.lds
Makefile +1 -1
index fceb8a2..6da4bff 100644
@@ -3145,7 +3145,7 @@ sh7785lcr_config  :   unconfig
 ap325rxa_config  :   unconfig
 	@mkdir -p $(obj)include
 	@echo "#define CONFIG_AP325RXA 1" > $(obj)include/config.h
-	@$(MKCONFIG) -a $(@:_config=) sh sh4 ap325rxa
+	@$(MKCONFIG) -a $(@:_config=) sh sh4 ap325rxa renesas
 
 #========================================================================
 # SPARC
board/ap325rxa/Makefile deleted +0 -51

51 lines not on this page · raw message

board/ap325rxa/ap325rxa.c deleted +0 -162

162 lines not on this page · raw message

board/ap325rxa/config.mk deleted +0 -26
deleted file mode 100644
index b52a5e5..0000000
@@ -1,26 +0,0 @@
-#
-# Copyright (C) 2007
-# Nobuhiro Iwamatsu <[email protected]>
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-
-#
-# TEXT_BASE refers to image _after_ relocation.
-#
-# NOTE: Must match value used in u-boot.lds (in this directory).
-#
-
-TEXT_BASE = 0x8FFC0000
board/ap325rxa/cpld-ap325rxa.c deleted +0 -206

206 lines not on this page · raw message

board/ap325rxa/lowlevel_init.S deleted +0 -243

243 lines not on this page · raw message

board/ap325rxa/u-boot.lds deleted +0 -105

105 lines not on this page · raw message

board/renesas/ap325rxa/Makefile new file +51 -0

51 lines not on this page · raw message

board/renesas/ap325rxa/ap325rxa.c new file +162 -0

162 lines not on this page · raw message

board/renesas/ap325rxa/config.mk new file +26 -0
new file mode 100644
index 0000000..b52a5e5
@@ -0,0 +1,26 @@
+#
+# Copyright (C) 2007
+# Nobuhiro Iwamatsu <[email protected]>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+
+#
+# TEXT_BASE refers to image _after_ relocation.
+#
+# NOTE: Must match value used in u-boot.lds (in this directory).
+#
+
+TEXT_BASE = 0x8FFC0000
board/renesas/ap325rxa/cpld-ap325rxa.c new file +206 -0

206 lines not on this page · raw message

board/renesas/ap325rxa/lowlevel_init.S new file +243 -0

243 lines not on this page · raw message

board/renesas/ap325rxa/u-boot.lds new file +105 -0

105 lines not on this page · raw message

Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/7 sh: ap325rxa: Moveed ap325rxa board in board/renesas

Hi Nobuhiro,
The titles for this patch series should be renamed with s/Moveed/Moved/ and maybe s/in/to/.

Also, git should be smart enough to know the files were moved as opposed to separate file deletions/creations. For example from "[PATCH 01/12]
gunzip: move to lib_generic":

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
---
 common/Makefile                  |    1 -
 lib_generic/Makefile             |    1 +
 {common => lib_generic}/gunzip.c |    0 
 3 files changed, 1 insertions(+), 1 deletions(-)
 rename {common => lib_generic}/gunzip.c (100%)
common/Makefile +0 -1
index 944b1c0..d974823 100644
@@ -36,7 +36,6 @@ COBJS-$(CONFIG_CMD_BDI) += cmd_bdinfo.o
 COBJS-$(CONFIG_CMD_BEDBUG) += cmd_bedbug.o
 COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o
 COBJS-y += image.o
-COBJS-y += gunzip.o
 COBJS-y += cmd_boot.o
 COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o
 COBJS-y += cmd_bootm.o
lib_generic/Makefile +1 -0
index bf0e31d..a820f97 100644
@@ -34,6 +34,7 @@ COBJS-y += crc32.o
 COBJS-y += ctype.o
 COBJS-y += display_options.o
 COBJS-y += div64.o
+COBJS-y += gunzip.o
 COBJS-y += lmb.o
 COBJS-y += ldiv.o
 COBJS-$(CONFIG_MD5) += md5.o
lib_generic/gunzip.c renamed from common/gunzip.c +0 -0
similarity index 100%
rename from common/gunzip.c
rename to lib_generic/gunzip.c

Maybe you have to explicitly use the "git mv" command, I'm not sure... Without git noticing the files were only moved I'm doubtful the moved files would retain their history log and only having the relevant file changes in the diff would clean up the patches significantly.

Best,
Peter

Quoted 28 lines · Nobuhiro Iwamatsu
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 Makefile                               |    2 +-
 board/ap325rxa/Makefile                |   51 -------
 board/ap325rxa/ap325rxa.c              |  162 ---------------------
 board/ap325rxa/config.mk               |   26 ----
 board/ap325rxa/cpld-ap325rxa.c         |  206 ---------------------------
 board/ap325rxa/lowlevel_init.S         |  243 --------------------------------
 board/ap325rxa/u-boot.lds              |  105 --------------
 board/renesas/ap325rxa/Makefile        |   51 +++++++
 board/renesas/ap325rxa/ap325rxa.c      |  162 +++++++++++++++++++++
 board/renesas/ap325rxa/config.mk       |   26 ++++
 board/renesas/ap325rxa/cpld-ap325rxa.c |  206 +++++++++++++++++++++++++++
 board/renesas/ap325rxa/lowlevel_init.S |  243 ++++++++++++++++++++++++++++++++
 board/renesas/ap325rxa/u-boot.lds      |  105 ++++++++++++++
 13 files changed, 794 insertions(+), 794 deletions(-)
 delete mode 100644 board/ap325rxa/Makefile
 delete mode 100644 board/ap325rxa/ap325rxa.c
 delete mode 100644 board/ap325rxa/config.mk
 delete mode 100644 board/ap325rxa/cpld-ap325rxa.c
 delete mode 100644 board/ap325rxa/lowlevel_init.S
 delete mode 100644 board/ap325rxa/u-boot.lds
 create mode 100644 board/renesas/ap325rxa/Makefile
 create mode 100644 board/renesas/ap325rxa/ap325rxa.c
 create mode 100644 board/renesas/ap325rxa/config.mk
 create mode 100644 board/renesas/ap325rxa/cpld-ap325rxa.c
 create mode 100644 board/renesas/ap325rxa/lowlevel_init.S
 create mode 100644 board/renesas/ap325rxa/u-boot.lds
author
#2 lore raw

PATCH 1/7 sh: ap325rxa: Moveed ap325rxa board in board/renesas

Hi, Peter.

Quoted 3 lines · On Tue, 28 Oct 2008 09:36:10 -0500 Peter Tyser <[email protected]> wrote:

Hi Nobuhiro,
The titles for this patch series should be renamed with s/Moveed/Moved/ and maybe s/in/to/.

Oh, Thanks.

Quoted 43 lines

Also, git should be smart enough to know the files were moved as opposed to separate file deletions/creations. For example from "[PATCH 01/12]
gunzip: move to lib_generic":

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
---
 common/Makefile                  |    1 -
 lib_generic/Makefile             |    1 +
 {common => lib_generic}/gunzip.c |    0 
 3 files changed, 1 insertions(+), 1 deletions(-)
 rename {common => lib_generic}/gunzip.c (100%)
common/Makefile +0 -1
index 944b1c0..d974823 100644
@@ -36,7 +36,6 @@ COBJS-$(CONFIG_CMD_BDI) += cmd_bdinfo.o
 COBJS-$(CONFIG_CMD_BEDBUG) += cmd_bedbug.o
 COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o
 COBJS-y += image.o
-COBJS-y += gunzip.o
 COBJS-y += cmd_boot.o
 COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o
 COBJS-y += cmd_bootm.o
lib_generic/Makefile +1 -0
index bf0e31d..a820f97 100644
@@ -34,6 +34,7 @@ COBJS-y += crc32.o
 COBJS-y += ctype.o
 COBJS-y += display_options.o
 COBJS-y += div64.o
+COBJS-y += gunzip.o
 COBJS-y += lmb.o
 COBJS-y += ldiv.o
 COBJS-$(CONFIG_MD5) += md5.o
lib_generic/gunzip.c renamed from common/gunzip.c +0 -0
similarity index 100%
rename from common/gunzip.c
rename to lib_generic/gunzip.c
Quoted 4 lines

Maybe you have to explicitly use the "git mv" command, I'm not sure... Without git noticing the files were only moved I'm doubtful the moved files would retain their history log and only having the relevant file changes in the diff would clean up the patches significantly.

OK, I will check and resend.

Thnak you for your check.

Best regards,
Nobuhiro

Signature · 1 line
Nobuhiro Iwamatsu
#3 lore raw

PATCH 1/7 sh: ap325rxa: Moveed ap325rxa board in board/renesas

Hi Nobuhiro,

Quoted 62 lines · Nobuhiro Iwamatsu

Hi, Peter.

Quoted 4 lines · On Tue, 28 Oct 2008 09:36:10 -0500 Peter Tyser <[email protected]> wrote:

Hi Nobuhiro,
The titles for this patch series should be renamed with s/Moveed/Moved/ and maybe s/in/to/.

Oh, Thanks.

Quoted 42 lines

Also, git should be smart enough to know the files were moved as opposed to separate file deletions/creations. For example from "[PATCH 01/12]
gunzip: move to lib_generic":

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
---
 common/Makefile                  |    1 -
 lib_generic/Makefile             |    1 +
 {common => lib_generic}/gunzip.c |    0 
 3 files changed, 1 insertions(+), 1 deletions(-)
 rename {common => lib_generic}/gunzip.c (100%)
common/Makefile +0 -1
index 944b1c0..d974823 100644
@@ -36,7 +36,6 @@ COBJS-$(CONFIG_CMD_BDI) += cmd_bdinfo.o
 COBJS-$(CONFIG_CMD_BEDBUG) += cmd_bedbug.o
 COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o
 COBJS-y += image.o
-COBJS-y += gunzip.o
 COBJS-y += cmd_boot.o
 COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o
 COBJS-y += cmd_bootm.o
lib_generic/Makefile +1 -0
index bf0e31d..a820f97 100644
@@ -34,6 +34,7 @@ COBJS-y += crc32.o
 COBJS-y += ctype.o
 COBJS-y += display_options.o
 COBJS-y += div64.o
+COBJS-y += gunzip.o
 COBJS-y += lmb.o
 COBJS-y += ldiv.o
 COBJS-$(CONFIG_MD5) += md5.o
lib_generic/gunzip.c renamed from common/gunzip.c +0 -0
similarity index 100%
rename from common/gunzip.c
rename to lib_generic/gunzip.c
Quoted 5 lines

Maybe you have to explicitly use the "git mv" command, I'm not sure... Without git noticing the files were only moved I'm doubtful the moved files would retain their history log and only having the relevant file changes in the diff would clean up the patches significantly.

OK, I will check and resend.

Quoted 5 lines

Thnak you for your check.

Best regards,
Nobuhiro

Use 'git mv' and then 'git format-patch -C'

regards,
Ben

author
#4 lore raw

PATCH 1/7 sh: ap325rxa: Moveed ap325rxa board in board/renesas

Hi, Ben.

Quoted 1 line · On Tue, 28 Oct 2008 09:35:09 -0700 Ben Warren <[email protected]> wrote:

Use 'git mv' and then 'git format-patch -C'

OK, Thank you.
I will use and resend.

Best regards,
Nobuhiro

Signature · 1 line
Nobuhiro Iwamatsu