Skip to contentSkip to conversation

SELinux: do not spam dmesg about unix domain sockets

PATCH In review Eric Paris 1 participant 1 message Oct 29, 2008 SELinux security module

lore
Share & tools
lore

Eric Paris

author
#0 lore raw

PATCH 2/2 SELinux: do not spam dmesg about unix domain sockets

unix sockets were able to get down the open code path. This simply matches exactly that request and does nothing with it. Should shut up the dmesg spam.

---

 security/selinux/hooks.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
security/selinux/hooks.c +5 -1
index 188284f..562844a 100644
@@ -1697,7 +1697,9 @@ static inline u32 open_file_mask_to_av(int mode, int mask)
 
 	if (selinux_policycap_openperm) {
 		/*
-		 * lnk files and socks do not really have an 'open'
+		 * lnk files do not really have an 'open'
+		 * unix domain sockets from unix_find_other can get here, so
+		 * do nothing with those requests...
 		 */
 		if (S_ISREG(mode))
 			av |= FILE__OPEN;
@@ -1710,6 +1712,8 @@ static inline u32 open_file_mask_to_av(int mode, int mask)
 		else if (S_ISDIR(mode)) {
 			if (mask != MAY_EXEC)
 				av |= DIR__OPEN;
+		} else if (S_ISSOCK(mode) && (mask == MAY_WRITE)) {
+			/* do nothing for stupid unix domain sockets */
 		} else
 			printk(KERN_ERR "SELinux: WARNING: inside %s with "
 				"unknown mode:%o mask:%x\n", __func__, mode, mask);

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.