Skip to contentSkip to conversation

UIO: uio_pdrv_genirq: allow custom irq_flags

PATCH Superseded Mike Frysinger 2 participants 2 messages Oct 29, 2008 Userspace I/O (UIO)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 UIO: uio_pdrv_genirq: allow custom irq_flags

I can't think of a reason why the driver prevents people from setting any custom bits in their platform device, but I can think of some reasons for allowing custom flags. Like setting the IRQF_TRIGGER_... bits.

---
 drivers/uio/uio_pdrv_genirq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/uio/uio_pdrv_genirq.c +2 -2
index 1f82c83..8695245 100644
@@ -81,7 +81,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
 		goto bad0;
 	}
 
-	if (uioinfo->handler || uioinfo->irqcontrol || uioinfo->irq_flags) {
+	if (uioinfo->handler || uioinfo->irqcontrol) {
 		dev_err(&pdev->dev, "interrupt configuration error\n");
 		goto bad0;
 	}
@@ -132,7 +132,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
 	 * Interrupt sharing is not supported.
 	 */
 
-	uioinfo->irq_flags = IRQF_DISABLED;
+	uioinfo->irq_flags |= IRQF_DISABLED;
 	uioinfo->handler = uio_pdrv_genirq_handler;
 	uioinfo->irqcontrol = uio_pdrv_genirq_irqcontrol;
 	uioinfo->priv = priv;
Signature · 1 line
1.6.0.2
#1 lore raw

ugh, it'd help if i selected the right patch on the cmd line ... -mike