Skip to contentSkip to conversation

driver core: Use 'ret' variable in unregister_dynamic_debug_module

PATCH In review Johann Felix Soden 2 participants 2 messages Oct 30, 2008 – Oct 31, 2008 Library code

lore
Share & tools
lore

Johann Felix Soden

author
#0 lore raw

PATCH 1/1 driver core: Use 'ret' variable in unregister_dynamic_debug_module

From: Johann Felix Soden <[email protected]>

The 'ret' variable is assigned, but not used in the return statement. Fix this.

Signed-off-by Johann Felix Soden <[email protected]>
CC Jason Baron <[email protected]>
---
 lib/dynamic_printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/dynamic_printk.c +1 -1
index d83660f..d0fd0e4 100644
@@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
 	nr_entries--;
 out:
 	up(&debug_list_mutex);
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
Signature · 1 line
1.5.6.5
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Johann Felix Soden

From: Johann Felix Soden <[email protected]>

The 'ret' variable is assigned, but not used in the return statement. Fix this.

Signed-off-by Johann Felix Soden <[email protected]>
CC Jason Baron <[email protected]>
---
 lib/dynamic_printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/dynamic_printk.c +0 -0
index d83660f..d0fd0e4 100644

lib/dynamic_printk.c int unregister_dynamic_debug_module(char *mod_name) · line 141

Quoted 8 lines
lib/dynamic_printk.c +1 -1
@@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
 	nr_entries--;
 out:
 	up(&debug_list_mutex);
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);

looks good to me.

Acked-by Jason Baron <[email protected]>

thanks,

-Jason