Skip to contentSkip to conversation

ftrace: ftrace_dump_on_oops=[tracer]

PATCH Applied Peter Zijlstra 3 participants 5 messages Nov 1, 2008 – Nov 3, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ftrace: ftrace_dump_on_oops=[tracer]

seems useful to debug crashes that happen before I read userspace.

---

Documentation/kernel-parameters.txt +4 -0
index d2c115b..74c27ee 100644
@@ -765,6 +765,10 @@ and is between 256 and 4096 characters. It is defined in the file
 			parameter will force ia64_sal_cache_flush to call
 			ia64_pal_cache_flush instead of SAL_CACHE_FLUSH.
 
+	ftrace_dump_on_oops=[tracer]
+			[ftrace] will dump the trace buffers on oops and
+			optionally set and start the specified tracer.
+
 	gamecon.map[2|3]=
 			[HW,JOY] Multisystem joystick and NES/SNES/PSX pad
 			support via parallel port (up to 5 devices per port)
kernel/trace/trace.c +32 -20

76 lines not on this page · raw message

maintainer
#1 lore raw
Quoted 1 line · Peter Zijlstra

seems useful to debug crashes that happen before I read userspace.

Hmm, I think it might be better to separate this from the dump_on_oops. How about a ftrace_default_tracer parameter?

If one is defined, it is activated as soon as it is initialized. This way we decouple the dump_on_oops, which we may not always want, and a way to start tracers before the switch to user space.

-- Steve

#2 lore raw
Quoted 10 lines · Steven Rostedt
Quoted 1 line · Peter Zijlstra

seems useful to debug crashes that happen before I read userspace.

Hmm, I think it might be better to separate this from the dump_on_oops. How about a ftrace_default_tracer parameter?

If one is defined, it is activated as soon as it is initialized. This way we decouple the dump_on_oops, which we may not always want, and a way to start tracers before the switch to user space.

Like so?

---
Subject: ftrace: enable setting an ftrace tracer on boot

In order to facilitate early boot trouble, allow one to specify a tracer on the kernel boot line.

---

Documentation/kernel-parameters.txt +8 -0
index d2c115b..4d694fd 100644
@@ -765,6 +765,14 @@ and is between 256 and 4096 characters. It is defined in the file
 			parameter will force ia64_sal_cache_flush to call
 			ia64_pal_cache_flush instead of SAL_CACHE_FLUSH.
 
+	ftrace=[tracer]
+			[ftrace] will set and start the specified tracer
+			as early as possible in order to facilitate early
+			boot debugging.
+
+	ftrace_dump_on_oops
+			[ftrace] will dump the trace buffers on oops.
+
 	gamecon.map[2|3]=
 			[HW,JOY] Multisystem joystick and NES/SNES/PSX pad
 			support via parallel port (up to 5 devices per port)
kernel/trace/trace.c +38 -20

79 lines not on this page · raw message

maintainer Acked-by
#3 lore raw
Quoted 5 lines · Peter Zijlstra
Quoted 4 lines · Steven Rostedt
Quoted 1 line · Peter Zijlstra

seems useful to debug crashes that happen before I read userspace.

Quoted 8 lines
Quoted 6 lines

Hmm, I think it might be better to separate this from the dump_on_oops. How about a ftrace_default_tracer parameter?

If one is defined, it is activated as soon as it is initialized. This way we decouple the dump_on_oops, which we may not always want, and a way to start tracers before the switch to user space.

Like so?

Sure.

Quoted 8 lines

---
Subject: ftrace: enable setting an ftrace tracer on boot

In order to facilitate early boot trouble, allow one to specify a tracer on the kernel boot line.

-- Steve

Applied
#4 lore raw
Quoted 23 lines · Steven Rostedt
Quoted 5 lines · Peter Zijlstra
Quoted 4 lines · Steven Rostedt
Quoted 1 line · Peter Zijlstra

seems useful to debug crashes that happen before I read userspace.

Quoted 8 lines
Quoted 6 lines

Hmm, I think it might be better to separate this from the dump_on_oops. How about a ftrace_default_tracer parameter?

If one is defined, it is activated as soon as it is initialized. This way we decouple the dump_on_oops, which we may not always want, and a way to start tracers before the switch to user space.

Like so?

Sure.

Quoted 4 lines

---
Subject: ftrace: enable setting an ftrace tracer on boot

Quoted 6 lines
Quoted 4 lines

In order to facilitate early boot trouble, allow one to specify a tracer on the kernel boot line.

applied to tip/tracing/ftrace, thanks guys!

Ingo