Skip to contentSkip to conversation

tun: don't set NETIF_F_FRAGLIST

PATCH New Mark McLoughlin 1 participant 1 message Nov 5, 2008

Subsystems (3)
Networking Network drivers TUN/TAP driver
lore
Share & tools
lore

Mark McLoughlin

author
#0 lore raw

PATCH 1/1 tun: don't set NETIF_F_FRAGLIST

We don't handle skb_shared_info->frag_list, so we shouldn't be setting the NETIF_F_FRAGLIST flag.

Signed-off-by Mark McLoughlin <[email protected]>
---
 drivers/net/tun.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/tun.c +2 -2
index 33b6d1b..7f9084c 100644
@@ -844,11 +844,11 @@ static int set_offload(struct net_device *dev, unsigned long arg)
 
 	old_features = dev->features;
 	/* Unset features, set them as we chew on the arg. */
-	features = (old_features & ~(NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST
+	features = (old_features & ~(NETIF_F_HW_CSUM|NETIF_F_SG
 				    |NETIF_F_TSO_ECN|NETIF_F_TSO|NETIF_F_TSO6));
 
 	if (arg & TUN_F_CSUM) {
-		features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
+		features |= NETIF_F_HW_CSUM|NETIF_F_SG;
 		arg &= ~TUN_F_CSUM;
 
 		if (arg & (TUN_F_TSO4|TUN_F_TSO6)) {
Signature · 1 line
1.5.4.3