Skip to contentSkip to conversation

ACPI: fix inconsistent acpi event format

PATCH New Yi Yang 1 participant 1 message Nov 5, 2008 ACPI

lore
Share & tools
lore

Yi Yang

author
#0 lore raw

PATCH 1/1 ACPI: fix inconsistent acpi event format

Subject: ACPI: fix inconsistent acpi event format
From: Yi Yang <[email protected]>

Event format acpi generates for /proc/acpi/event is different from that for generic netlink interface. Here are i got:

Quoted 1 line

From /proc/acpi/event, i got the following events when i suspend and

resume Acer's Aspire One:

battery BAT1 00000080 00000000
battery BAT1 00000081 00000000
ac_adapter ACAD 00000080 00000001
battery BAT1 00000080 00000000

But from generic netlink socket, i got the following events when i suspend and resume Acer's Aspire One:

battery PNP0C0A:00 00000080 00000000
battery PNP0C0A:00 00000081 00000000
ac_adapter ACPI0003:00 00000080 00000001
battery PNP0C0A:00 00000080 00000000

Such inconsistent event format will make acpid or hald confused, this patch fixes this issue, it makes acpid or hald see the same thing no matter they use /proc/acpi/event or generic netlink interface.

After applying this patch, event format i got from /proc/acpi/event and generic netlink interface is same, all of them are:

battery BAT1 00000080 00000000
battery BAT1 00000081 00000000
ac_adapter ACAD 00000080 00000001
battery BAT1 00000080 00000000

Please consider applying, thanks.

---
 battery.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/battery.c +1 -1
index b2133e8..e52b336 100644
@@ -782,7 +782,7 @@ static void acpi_battery_notify(acpi_handle handle, u32 event, void *data)
 	acpi_bus_generate_proc_event(device, event,
 				     acpi_battery_present(battery));
 	acpi_bus_generate_netlink_event(device->pnp.device_class,
-					device->dev.bus_id, event,
+					device->pnp.bus_id, event,
 					acpi_battery_present(battery));
 #ifdef CONFIG_ACPI_SYSFS_POWER
 	/* acpi_batter_update could remove power_supply object */