Skip to contentSkip to conversation

KVM: x86: enable -Werror

PATCH linmiaohe 3 participants 3 messages Feb 13, 2020 KVM

lore
Share & tools
lore
#1 lore raw
Quoted 5 lines · linmiaohe
Quoted 4 lines · Paolo Bonzini

Avoid more embarrassing mistakes. At least those that the compiler can catch.

---

I think adding -Werror is a bad idea as new versions of compilers can create additional compilation warnings and break builds in the future.

maintainer
#2 lore raw
Quoted 10 lines · Joe Perches
Quoted 5 lines · linmiaohe
Quoted 4 lines · Paolo Bonzini

Avoid more embarrassing mistakes. At least those that the compiler can catch.

---

I think adding -Werror is a bad idea as new versions of compilers can create additional compilation warnings and break builds in the future.

Seems like cargo culting (in the reverse) to me. We can cross the bridge when we get there.

Paolo