Skip to contentSkip to conversation

x86: x86_32 has its own irq_regs definition

PATCH Applied Harvey Harrison 2 participants 2 messages Nov 10, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: x86_32 has its own irq_regs definition

Impact: prevent second percpu define of unused irq_regs

Arches that have their own irq_regs definition are expected to define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set will also be defined in lib/irq_regs.c

Sparse noticed the unused generic one had no prototype:
lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?

---
 arch/x86/include/asm/irq_regs_32.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/include/asm/irq_regs_32.h +2 -0
index af2f02d..86afd74 100644
@@ -9,6 +9,8 @@
 
 #include <asm/percpu.h>
 
+#define ARCH_HAS_OWN_IRQ_REGS
+
 DECLARE_PER_CPU(struct pt_regs *, irq_regs);
 
 static inline struct pt_regs *get_irq_regs(void)
Signature · 1 line
1.6.0.3.866.gc189b
Applied
#1 lore raw
Quoted 6 lines · Harvey Harrison

Impact: prevent second percpu define of unused irq_regs

Arches that have their own irq_regs definition are expected to define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set will also be defined in lib/irq_regs.c

Quoted 7 lines

Sparse noticed the unused generic one had no prototype:
lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?

---
 arch/x86/include/asm/irq_regs_32.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

applied to tip/x86/cleanups, thanks Harvey!

Ingo