Skip to contentSkip to conversation

lib: fix sparse shadowed variable warning

PATCH New Harvey Harrison 1 participant 1 message Nov 10, 2008 Library code

lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 1/3 lib: fix sparse shadowed variable warning

pos is always set before being used, no need to declare a second one inside the if() block.

lib/prio_heap.c:34:7: warning: symbol 'pos' shadows an earlier one lib/prio_heap.c:30:6: originally declared here

Signed-off-by Harvey Harrison <[email protected]>
---
 lib/prio_heap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/prio_heap.c +1 -1
index 471944a..a7af6f8 100644
@@ -31,7 +31,7 @@ void *heap_insert(struct ptr_heap *heap, void *p)
 
 	if (heap->size < heap->max) {
 		/* Heap insertion */
-		int pos = heap->size++;
+		pos = heap->size++;
 		while (pos > 0 && heap->gt(p, ptrs[(pos-1)/2])) {
 			ptrs[pos] = ptrs[(pos-1)/2];
 			pos = (pos-1)/2;
Signature · 1 line
1.6.0.3.866.gc189b