OneNAND: Fix compiler warnings
PATCH 1/1 OneNAND: Fix compiler warnings
---
This patch has to be applied on top of the patch submitted by Kyungmin Park on 2008-11-04:
[PATCH] [OneNAND] Sync with 2.6.27
It replaces my patch "[PATCH] OneNAND: Fix compiler warnings and add weak attribute to memcpy_16()". The weak method is not needed. Thanks to Scott for pointing this out.
drivers/mtd/onenand/onenand_base.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-)
drivers/mtd/onenand/onenand_base.c +26 -0
@@ -409,6 +409,30 @@ static int onenand_write_bufferram(struct mtd_info *mtd, loff_t addr, int area, }/** +* onenand_get_2x_blockpage - [GENERIC] Get blockpage at 2x program mode +* @param mtd MTD data structure +* @param addr address to check +* @return blockpage address +* +* Get blockpage address at 2x program mode +*/ +static int onenand_get_2x_blockpage (struct mtd_info *mtd,loff_t addr) +{ +struct onenand_chip *this = mtd->priv; +int blockpage, block, page; + +/* Calculate the even block number */ + block = (int ) (addr >> this->erase_shift) & ~1 ; +/* Is it the odd plane? */ +if (addr & this->writesize) + block++; + page = (int ) (addr >> (this->page_shift +1 )) & this->page_mask; + blockpage = (block <<7 ) | page; + +return blockpage; +} + +/** * onenand_check_bufferram - [GENERIC] Check BufferRAM information * @param mtd MTD data structure * @param addr address to check
@@ -1666,6 +1690,7 @@ static int onenand_do_lock_cmd(struct mtd_info *mtd, loff_t ofs, size_t len, intreturn 0 ; } +#ifdef ONENAND_LINUX /** * onenand_lock - [MTD Interface] Lock block(s) * @param mtd MTD device structure
@@ -1701,6 +1726,7 @@ static int onenand_unlock(struct mtd_info *mtd, loff_t ofs, size_t len)onenand_release_device (mtd); return ret; } +#endif /** * onenand_check_lock_status - [OneNAND Interface] Check lock status
Signature · 1 line
1.6.0.4
PATCH 1/1 OneNAND: Fix compiler warnings
Quoted 9 lines · Stefan Roese
Signed-off-by Stefan Roese <[email protected]>---
This patch has to be applied on top of the patch submitted by Kyungmin Park on 2008-11-04:
[PATCH] [OneNAND] Sync with 2.6.27It replaces my patch "[PATCH] OneNAND: Fix compiler warnings and add weak attribute to
memcpy_16()". The weak method is not needed. Thanks to Scott for pointing this out.
Applied to u-boot-nand-flash/next
-Scott
PATCH 1/1 OneNAND: Fix compiler warnings
In reply to Stefan RoeseHi all,
Quoted 5 lines · In message <[email protected]> you wrote:
Signed-off-by Stefan Roese <[email protected]>---
This patch has to be applied on top of the patch submitted by Kyungmin Park on 2008-11-04:
[PATCH] [OneNAND] Sync with 2.6.27
I have to admit that I completely lost track of all the OneNAND patches floating around and being sent and resent and resent again.
This is especially the case since none of the boards I am familiar with uses OneNAND, sso I have zero experience and little ways to test anything.
In short: we need a OneNAND custodian, and we need him badly.
Is any of you volunteering, or knows of a potential candidate?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Everybody is talking about the weather but nobody does anything about it." - Mark Twain
PATCH 1/1 OneNAND: Fix compiler warnings
Quoted 12 lines · Wolfgang Denk
Hi all,
Quoted 5 lines · In message <[email protected]> you wrote:
Signed-off-by Stefan Roese <[email protected]>---
This patch has to be applied on top of the patch submitted by Kyungmin Park on 2008-11-04:
[PATCH] [OneNAND] Sync with 2.6.27I have to admit that I completely lost track of all the OneNAND patches floating around and being sent and resent and resent again.
Quoted 9 lines
This is especially the case since none of the boards I am familiar with uses OneNAND, sso I have zero experience and little ways to test anything.
In short: we need a OneNAND custodian, and we need him badly.
Is any of you volunteering, or knows of a potential candidate?
Stefan,
Even though It's some difficult to access the external server, I can access http protocol. So I can pull the git. So if you control the git then I generate and send a patch against the OneNAND tree.
Or other ideas?
Thank you,
Kyungmin Park
PATCH 1/1 OneNAND: Fix compiler warnings
Quoted 11 lines · Kyungmin Park
Quoted 3 lines
In short: we need a OneNAND custodian, and we need him badly.
Is any of you volunteering, or knows of a potential candidate?
Stefan,
Even though It's some difficult to access the external server, I can access http protocol. So I can pull the git. So if you control the git then I generate and send a patch against the OneNAND tree.
Or other ideas?
Till now Scott has takes care of the OneNAND related patches in his NAND repository. The latest patches are already present in his next branch, IIRC.
I'm not sure how you feel about this Scott. Are you willing to officially handle this OneNAND stuff further?
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 OneNAND: Fix compiler warnings
HI
----- Original Message -----
From: "Stefan Roese" <[email protected]>
To: "Kyungmin Park" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Tuesday, December 09, 2008 11:57 AM
Subject: Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings
Quoted 4 lines · Kyungmin Park
Quoted 3 lines
Quoted 3 lines
In short: we need a OneNAND custodian, and we need him badly.
I would like to work as OneNAND custodian ,Our team is already working for FlexOneNAND related parts , what is opinion of you guys.
Quoted 38 lines
Quoted 5 lines
Quoted 2 lines
Is any of you volunteering, or knows of a potential candidate?
Stefan,
Quoted 8 lines
Even though It's some difficult to access the external server, I can
access http protocol. So I can pull the git. So if you control the git
then I generate and send a patch against the OneNAND tree.Or other ideas?
Till now Scott has takes care of the OneNAND related patches in his NAND
repository. The latest patches are already present in his next branch, IIRC.I'm not sure how you feel about this Scott. Are you willing to officially
handle this OneNAND stuff further?Best regards,
Stefan=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk &
Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email:
office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH 1/1 OneNAND: Fix compiler warnings
Hi Amit,
Quoted 6 lines · Amit Kumar Sharma
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
In short: we need a OneNAND custodian, and we need him badly.
I would like to work as OneNAND custodian ,Our team is already working for FlexOneNAND related parts , what is opinion of you guys.
Guessing from your email address, you are a co-worker of Kyungmin. Correct? Don't you have the same problems accessing the DENX git repositories as Kyungmin has?
Please don't get me wrong. I would really appreciate if you (and/or Kyungmin) would become the OneNAND custodian (if we really decide that we should create such a custodianship). Just checking if the infrastructure if working for you.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 OneNAND: Fix compiler warnings
Hi Stefan,
Quoted 11 lines
Hi Amit,
Quoted 7 lines · Amit Kumar Sharma
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
In short: we need a OneNAND custodian, and we need him
badly.I would like to work as OneNAND custodian ,Our team is already working for FlexOneNAND related parts , what is opinion of you guys.
Quoted 6 lines
Guessing from your email address, you are a co-worker of Kyungmin. Correct?
Don't you have the same problems accessing the DENX git repositories as
Kyungmin has?
Kyungmin and my team part of Samsung but in different divisions, I will check in my company about accessing DENX git reposotories,Let you know hope we can find some solution here.
Quoted 7 lines
Please don't get me wrong. I would really appreciate if you (and/or Kyungmin)
would become the OneNAND custodian (if we really decide that we should create
such a custodianship). Just checking if the infrastructure if working for
you.
regarding cowork kyungmin can take call , we have no
problem as cowork or working independent.
I show our interest because I feel by kyungmin mail , he has difficulty and busy with many other activities.
Thanks.
Best regards,
Amit Kumar Sharma
Quoted 8 lines
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk &
Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email:
office at denx.de
=====================================================================
PATCH 1/1 OneNAND: Fix compiler warnings
In reply to Stefan RoeseQuoted 5 lines · Stefan Roese
Till now Scott has takes care of the OneNAND related patches in his NAND repository. The latest patches are already present in his next branch, IIRC.
I'm not sure how you feel about this Scott. Are you willing to officially handle this OneNAND stuff further?
I'm willing to continue, though if someone more familiar with OneNAND and with access to hardware wanted to take it over I'd be fine with that too.
-Scott
PATCH 1/1 OneNAND: Fix compiler warnings
Dear Scott,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 5 lines · Stefan Roese
Till now Scott has takes care of the OneNAND related patches in his NAND repository. The latest patches are already present in his next branch, IIRC.
I'm not sure how you feel about this Scott. Are you willing to officially handle this OneNAND stuff further?
I'm willing to continue, though if someone more familiar with OneNAND and with access to hardware wanted to take it over I'd be fine with that too.
Thanks for the clarification.
I have this patch marked as open, and cannot find any comments for it in the archive:
11/10 Kyungmin Park [U-Boot] [PATCH] [ONENAND] Reduce OneNAND IPL code size v2
Could you please have a look? THanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's all Klatchian to me.
- Terry Pratchett & Stephen Briggs, _The Discworld Companion_PATCH 1/1 OneNAND: Fix compiler warnings
Quoted 13 lines · Wolfgang Denk
Dear Scott,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 5 lines · Stefan Roese
Till now Scott has takes care of the OneNAND related patches in his NAND repository. The latest patches are already present in his next branch, IIRC.
I'm not sure how you feel about this Scott. Are you willing to officially handle this OneNAND stuff further?
I'm willing to continue, though if someone more familiar with OneNAND and with access to hardware wanted to take it over I'd be fine with that too.
Quoted 9 lines
Thanks for the clarification.
I have this patch marked as open, and cannot find any comments for it in the archive:
11/10 Kyungmin Park [U-Boot] [PATCH] [ONENAND] Reduce OneNAND IPL code size v2
Could you please have a look? THanks.
Thank you for Scott
Continue to work with Scott as before and make a custodian if it's needed. I will send OneNAND and IPL codes for merge tomorrow.
Plan: I worked OneNAND on several platform, S3C6410, PXA3xx, OMAP3 with different u-boot code base. So I want to merge this just one tree. actually PXA3xx and OMAP3 has same interface but s3c6410 doesn't. it has own OneNAND controller and difficult to use it.
Thank you,
Kyungmin Park