dvb: cinergyt2 annotate struct endiannes, remove unused variable, add static
PATCH 1/1 dvb: cinergyt2 annotate struct endiannes, remove unused variable, add static
All noticed by sparse:drivers/media/dvb/dvb-usb/cinergyT2-core.c:35:5: warning: symbol 'disable_remote' was not declared. Should it be static? drivers/media/dvb/dvb-usb/cinergyT2-core.c:48:23: warning: symbol 'cinergyt2_usb_device' was not declared. Should it be static? drivers/media/dvb/dvb-usb/cinergyT2-fe.c:160:15: warning: cast to restricted __le16 drivers/media/dvb/dvb-usb/cinergyT2-fe.c:190:9: warning: cast to restricted __le32 drivers/media/dvb/dvb-usb/cinergyT2-fe.c:208:9: warning: cast to restricted __le32 drivers/media/dvb/dvb-usb/cinergyT2-fe.c:227:24: warning: cast to restricted __le16 drivers/media/dvb/dvb-usb/cinergyT2-fe.c:275:12: warning: incorrect type in assignment (different base types)drivers/media/dvb/dvb-usb/cinergyT2-fe.c:275:12: expected unsigned short [unsigned] [assigned] [usertype] tpsdrivers/media/dvb/dvb-usb/cinergyT2-fe.c:275:12: got restricted __le16 [usertype] <noident>drivers/media/dvb/dvb-usb/cinergyT2-fe.c:276:13: warning: incorrect type in assignment (different base types)drivers/media/dvb/dvb-usb/cinergyT2-fe.c:276:13: expected unsigned int [unsigned] [assigned] [usertype] freqdrivers/media/dvb/dvb-usb/cinergyT2-fe.c:276:13: got restricted __le32 [usertype] <noident>
--- drivers/media/dvb/dvb-usb/cinergyT2-core.c | 3 +-- drivers/media/dvb/dvb-usb/cinergyT2.h | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-)
drivers/media/dvb/dvb-usb/cinergyT2-core.c +1 -2
@@ -32,7 +32,6 @@/* debug */ int dvb_usb_cinergyt2_debug; -int disable_remote;module_param_named (debug, dvb_usb_cinergyt2_debug, int,0644 ); MODULE_PARM_DESC(debug, "set debugging level (1=info, xfer=2, rc=4 "
@@ -45,7 +44,7 @@ struct cinergyt2_state { };/* We are missing a release hook with usb_device data */ -struct dvb_usb_device *cinergyt2_usb_device; +static struct dvb_usb_device *cinergyt2_usb_device;static struct dvb_usb_device_properties cinergyt2_properties;
drivers/media/dvb/dvb-usb/cinergyT2.h +5 -5
@@ -70,11 +70,11 @@ struct dvbt_get_status_msg {uint8_t bandwidth;uint16_t tps;uint8_t flags; -uint16_t gain; +__le16 gain;uint8_t snr; -uint32_t viterbi_error_rate; +__le32 viterbi_error_rate;uint32_t rs_error_rate; -uint32_t uncorrected_block_count; +__le32 uncorrected_block_count;uint8_t lock_bits;uint8_t prev_lock_bits; } __attribute__((packed));
@@ -82,9 +82,9 @@ struct dvbt_get_status_msg {struct dvbt_set_parameters_msg {uint8_t cmd; -uint32_t freq; +__le32 freq;uint8_t bandwidth; -uint16_t tps; +__le16 tps;uint8_t flags; } __attribute__((packed));
Signature · 1 line
1.6.0.4.879.g9d19a