Skip to contentSkip to conversation

ipc: do not goto to the next line

PATCH In review Denis V. Lunev 2 participants 2 messages Nov 17, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipc: do not goto to the next line

---
 ipc/sem.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
ipc/sem.c +0 -1
index 0821224..b91d455 100644
@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
 	if (timeout && jiffies_left == 0)
 		error = -EAGAIN;
 	list_del(&queue.list);
-	goto out_unlock_free;
 
 out_unlock_free:
 	sem_unlock(sma);
Signature · 1 line
1.5.6.4
Reviewed-by WANG Cong on v1 1/1
#1 lore raw
Quoted 16 lines · Denis V. Lunev

---
ipc/sem.c | 1 -

1 files changed, 0 insertions(+), 1 deletions(-)
ipc/sem.c +0 -1
index 0821224..b91d455 100644
@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
 	if (timeout && jiffies_left == 0)
 		error = -EAGAIN;
 	list_del(&queue.list);
-	goto out_unlock_free;
 

out_unlock_free:

Quoted 1 line
	sem_unlock(sma);

Aha, this goto is obviously useless. :)

If you need,

Signature · 1 line
"Sometimes the only way to stay sane is to go a little crazy."