Skip to contentSkip to conversation

Question regarding OMAP NAND driver read_buf16() function

DISCUSSION Peter Barada 2 participants 2 messages Nov 20, 2008

lore
Share & tools
lore
#0 lore raw

In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:

	__raw_readsl(nand->IO_ADDR_R, buf, len / 2);

Since len is in bytes (from the comment), shouldn't this either be:

	__raw_readsl(nand->IO_ADDR_R, buf, len / 4);

or:

	__raw_readsw(nand->IO_ADDR_R, buf, len / 2);
Signature · 9 lines
Peter Barada // senior software engineer
 
LOGIC // embedded product solutions
411 Washington Ave. N. Suite 400
Minneapolis, MN 55401
M // 617.513.5874
 
[email protected]
www.logicpd.com
#1 lore raw
Quoted 4 lines · Peter Barada

In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:

        __raw_readsl(nand->IO_ADDR_R, buf, len / 2);

Quoted 8 lines

Since len is in bytes (from the comment), shouldn't this either be:

        __raw_readsl(nand->IO_ADDR_R, buf, len / 4);

or:

        __raw_readsw(nand->IO_ADDR_R, buf, len / 2);

Current GIT has the latter. Upgrde your kernel. ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html