tg3: Allow GPHY powerdown on 5761
Subsystems (2)
PATCH 7/10 tg3: Allow GPHY powerdown on 5761
The ENABLE_APE flag tells the driver whether or not the device has an Application Processing Engine (APE). The APE does not need the PHY to be powered unless it is running management firmware. For backwards compatibility, management firmware will still set the ENABLE_ASF bit. Consequently, there is no reason to consider the ENABLE_APE flag when deciding whether or not to power down the phy.
--- drivers/net/tg3.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/tg3.c +1 -2
@@ -2400,8 +2400,7 @@ static int tg3_set_power_state(struct tg3 *tp, pci_power_t state) }if (!(device_should_wake) && - !(tp->tg3_flags &TG3_FLAG_ENABLE_ASF ) && - !(tp->tg3_flags3 &TG3_FLG3_ENABLE_APE )) + !(tp->tg3_flags &TG3_FLAG_ENABLE_ASF ))tg3_power_down_phy (tp, do_low_power);tg3_frob_aux_power (tp);
Signature · 1 line
1.5.6.4
From: "Matt Carlson" <[email protected]>
Date: Fri, 21 Nov 2008 11:02:15 -0800
Quoted 9 lines
The
ENABLE_APEflag tells the driver whether or not the device has an Application Processing Engine (APE). The APE does not need the PHY to be powered unless it is running management firmware. For backwards compatibility, management firmware will still set theENABLE_ASFbit. Consequently, there is no reason to consider theENABLE_APEflag when deciding whether or not to power down the phy.Signed-off-by Matt Carlson <[email protected]>Signed-off-by Michael Chan <[email protected]>
Applied.