Skip to contentSkip to conversation

kvm: header-sync: fix to work with 2.6.28 kernel

PATCH Applied Mark McLoughlin 2 participants 2 messages Nov 24, 2008 – Nov 26, 2008 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: header-sync: fix to work with 2.6.28 kernel

If you run header-sync against a kernel which has asm/kvm.h but not e.g. asm/vmx.h then $(wildcard $(headers-new)) returns a string with expanded kvm.h path and the vmx.h glob removed. We then pass the original globs to rsync causing that to fail when vmx.h can't be found:

rsync: link_stat ".../asm/vmx*.h" failed: No such file or directory (2)

Fix by passing the expanded paths returned by the wildcard function to rsync.

---
 kernel/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/Makefile +1 -1
index 33d6a84..eaf1c8e 100644
@@ -71,7 +71,7 @@ header-sync:
              $T/
 	$(if $(wildcard $(headers-new)), \
 	rsync -R \
-	     $(headers-new) \
+	     $(wildcard $(headers-new)) \
              $T/include/asm-$(ARCH_DIR)/)
 
 	for i in $$(find $T -name '*.h'); do \
Signature · 1 line
1.6.0.3
Applied
#1 lore raw
Quoted 11 lines · Mark McLoughlin

If you run header-sync against a kernel which has asm/kvm.h but not e.g. asm/vmx.h then $(wildcard $(headers-new)) returns a string with expanded kvm.h path and the vmx.h glob removed. We then pass the original globs to rsync causing that to fail when vmx.h can't be found:

rsync: link_stat ".../asm/vmx*.h" failed: No such file or directory (2)

Fix by passing the expanded paths returned by the wildcard function to rsync.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function