byteorder: add load_/store_{endian} API
PATCH 1/7 byteorder: add load_/store_{endian} API
load_le16 is a synonym for the existing le16_to_cpup and is added to be symmetric with the load_le16_noalign API. On arches where unaligned access is OK, the unaligned calls are replaced with aligned calls.
store_le16 is a new API and is added to be symmetric with the unaligned functions. It is implemented as a macro to allow compile-time byteswapping when the value is a constant. This will also allow use in many places currently that are of the form:
*(__le16 *)ptr = cpu_to_le16(foo);
In addition, some drivers/filesystems/arches already provide this API privately, which will allow them to be consolidated into this common code.
---
Andrew, the series become shorter if I just wire the aligned versions first and then use them in the unaligned headers.
include/linux/byteorder.h | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-)
include/linux/byteorder.h +20 -6
@@ -292,6 +292,20 @@ static inline __be64 __cpu_to_be64p(const __u64 *p)# define cpu_to_be32 __cpu_to_be32# define cpu_to_be64 __cpu_to_be64 +# define load_le16 __le16_to_cpup +# define load_le32 __le32_to_cpup +# define load_le64 __le64_to_cpup +# define load_be16 __be16_to_cpup +# define load_be32 __be32_to_cpup +# define load_be64 __be64_to_cpup + +# define store_le16 (p, val) (*(__le16 *)(p) = cpu_to_le16(val)) +# define store_le32 (p, val) (*(__le32 *)(p) = cpu_to_le32(val)) +# define store_le64 (p, val) (*(__le64 *)(p) = cpu_to_le64(val)) +# define store_be16 (p, val) (*(__be16 *)(p) = cpu_to_be16(val)) +# define store_be32 (p, val) (*(__be32 *)(p) = cpu_to_be32(val)) +# define store_be64 (p, val) (*(__be64 *)(p) = cpu_to_be64(val)) +# define le16_to_cpup __le16_to_cpup# define le32_to_cpup __le32_to_cpup# define le64_to_cpup __le64_to_cpup
@@ -340,32 +354,32 @@ static inline __be64 __cpu_to_be64p(const __u64 *p)static inline void le16_add_cpu (__le16 *var,u16 val) { - *var =cpu_to_le16 (le16_to_cpup (var) + val); +store_le16 (var,load_le16 (var) + val); }static inline void le32_add_cpu (__le32 *var,u32 val) { - *var =cpu_to_le32 (le32_to_cpup (var) + val); +store_le32 (var,load_le32 (var) + val); }static inline void le64_add_cpu (__le64 *var,u64 val) { - *var =cpu_to_le64 (le64_to_cpup (var) + val); +store_le64 (var,load_le64 (var) + val); }static inline void be16_add_cpu (__be16 *var,u16 val) { - *var =cpu_to_be16 (be16_to_cpup (var) + val); +store_be16 (var,load_be16 (var) + val); }static inline void be32_add_cpu (__be32 *var,u32 val) { - *var =cpu_to_be32 (be32_to_cpup (var) + val); +store_be32 (var,load_be32 (var) + val); }static inline void be64_add_cpu (__be64 *var,u64 val) { - *var =cpu_to_be64 (be64_to_cpup (var) + val); +store_be64 (var,load_be64 (var) + val); }#endif /* __KERNEL__ */
Signature · 1 line
1.6.0.4.1044.g77718