Skip to contentSkip to conversation

bluetooth: Dell Wireless 365 requires reset quirk

PATCH In review [email protected] 4 participants 4 messages Dec 1, 2008 – Dec 2, 2008 2 messages not in the archive

Subsystems (3)
Networking Network drivers Bluetooth drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 bluetooth: Dell Wireless 365 requires reset quirk

From: Mario Limonciello <[email protected]>

This patch causes the BT365 to be reset when the driver is loaded. Without it, the machine is unable to connect to other devices or to scan for devices.

Signed-off-by Mario Limonciello <[email protected]>
Signed-off-by Tim Gardner <[email protected]>
Cc Marcel Holtmann <[email protected]>
Cc Dave Young <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/bluetooth/btusb.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/bluetooth/btusb.c renamed from drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk +3 -0
diff -puN drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk drivers/bluetooth/btusb.c
@@ -125,6 +125,9 @@ static struct usb_device_id blacklist_ta
 	/* Dell laptop with Broadcom chip */
 	{ USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
 
+	/* Dell Wireless 365 */
+	{ USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET },
+
 	/* Dell Wireless 370 */
 	{ USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },

_

maintainer
#1 lore raw

Hi Andrew,

Quoted 10 lines

This patch causes the BT365 to be reset when the driver is loaded. Without it, the machine is unable to connect to other devices or to scan for devices.

Signed-off-by Mario Limonciello <[email protected]>
Signed-off-by Tim Gardner <[email protected]>
Cc Marcel Holtmann <[email protected]>
Cc Dave Young <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

NAK. I fixed this differently by making the reset quirk default.

Regards

Marcel

A message that is not in the archive (sent off-list or not yet received): 1228169030.31158.154.camel-Q5NHXjiL5LzjRizqIHwDm9HuzzzSOjJt@public.gmane.org

#3 lore raw
Quoted 13 lines · Marcel Holtmann

Hi Andrew,

Quoted 10 lines

This patch causes the BT365 to be reset when the driver is loaded. Without it, the machine is unable to connect to other devices or to scan for devices.

Signed-off-by Mario Limonciello <[email protected]>
Signed-off-by Tim Gardner <[email protected]>
Cc Marcel Holtmann <[email protected]>
Cc Dave Young <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Quoted 7 lines

NAK. I fixed this differently by making the reset quirk default.

Regards

Marcel

Does that mean the devices in blacklist_table that have _only_ BTUSB_RESET should be removed? It would get rid of roughly half of the entries.

rtg

Signature · 1 line
Tim Gardner [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

Hi Tim,

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

This patch causes the BT365 to be reset when the driver is loaded. Without it, the machine is unable to connect to other devices or to scan for devices.

Signed-off-by Mario Limonciello <[email protected]>
Signed-off-by Tim Gardner <[email protected]>
Cc Marcel Holtmann <[email protected]>
Cc Dave Young <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Quoted 5 lines
Quoted 1 line

NAK. I fixed this differently by making the reset quirk default.

Does that mean the devices in blacklist_table that have _only_ BTUSB_RESET should be removed? It would get rid of roughly half of the entries.

that has already been done. See the pull request I sent to Dave.

Regards

Marcel