Skip to contentSkip to conversation

crypto: talitos - Fix modpost warning

PATCH In review Kumar Gala 2 participants 4 messages Dec 3, 2008 Crypto API

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 crypto: talitos - Fix modpost warning

Removed __devexit from talitos_remove() since its also called from talitos_probe().

WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the function talitos_probe() to the function .devexit.text:talitos_remove() The function talitos_probe() references a function in an exit section.
Often the function talitos_remove() has valid usage outside the exit section
and the fix is to remove the __devexit annotation of talitos_remove.

Signed-off-by Kumar Gala <[email protected]>
---
 drivers/crypto/talitos.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/crypto/talitos.c +1 -1
index b6ad3ac..2479348 100644
@@ -1357,7 +1357,7 @@ static int hw_supports(struct device *dev, __be32 desc_hdr_template)
 	return ret;
 }
 
-static int __devexit talitos_remove(struct of_device *ofdev)
+static int talitos_remove(struct of_device *ofdev)
 {
 	struct device *dev = &ofdev->dev;
 	struct talitos_private *priv = dev_get_drvdata(dev);
Signature · 1 line
1.5.6.5
maintainer
#1 lore raw
Quoted 9 lines · Kumar Gala

Removed __devexit from talitos_remove() since its also called from talitos_probe().

WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the function talitos_probe() to the function .devexit.text:talitos_remove() The function talitos_probe() references a function in an exit section.
Often the function talitos_remove() has valid usage outside the exit section
and the fix is to remove the __devexit annotation of talitos_remove.

Signed-off-by Kumar Gala <[email protected]>

OK, but what about the __devexit_p reference on talitos_remove? We should remove that too.

Thanks,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
author
#2 lore raw
Quoted 9 lines · Herbert Xu
Quoted 8 lines · Kumar Gala

Removed __devexit from talitos_remove() since its also called from talitos_probe().

WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the function talitos_probe() to the function .devexit.text:talitos_remove() The function talitos_probe() references a function in an exit section.
Often the function talitos_remove() has valid usage outside the exit section
and the fix is to remove the __devexit annotation of talitos_remove.

Quoted 4 lines
Quoted 1 line
Signed-off-by Kumar Gala <[email protected]>

OK, but what about the __devexit_p reference on talitos_remove? We should remove that too.

missed that one. will fix up and post a new patch.

- k

author
#3 lore raw
Quoted 12 lines · Kumar Gala
Quoted 9 lines · Herbert Xu
Quoted 8 lines · Kumar Gala

Removed __devexit from talitos_remove() since its also called from talitos_probe().

WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the function talitos_probe() to the function .devexit.text:talitos_remove() The function talitos_probe() references a function in an exit section.
Often the function talitos_remove() has valid usage outside the exit section
and the fix is to remove the __devexit annotation of talitos_remove.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Kumar Gala <[email protected]>

OK, but what about the __devexit_p reference on talitos_remove? We should remove that too.

missed that one. will fix up and post a new patch.

Nevermind. Al bet me to this fix :)

- k