Skip to contentSkip to conversation

arm64: dts: ti: k3-j721s2: Fix the interrupt ranges property for main & wkup gpio intr

PATCH Applied Keerthy 3 participants 3 messages Sep 22, 2022 – Nov 17, 2022

Subsystems (2)
lore
Share & tools
lore

Keerthy

author
#0 lore raw

PATCH 1/1 arm64: dts: ti: k3-j721s2: Fix the interrupt ranges property for main & wkup gpio intr

The parent's input irq number is wrongly subtracted with 32 instead of using the exact numbers in:

https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html

The GPIO interrupts are not working because of that. The toggling works fine but interrupts are not firing. Fix the parent's input irq that specifies the base for parent irq.

Tested for MAIN_GPIO0_6 interrupt on the j721s2 EVM.

Fixes b8545f9d3a542 ("arm64: dts: ti: Add initial support for J721S2 SoC")
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi       | 2 +-
 arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +1 -1
index 34e7d577ae13..c89f28235812 100644
@@ -60,7 +60,7 @@
 		#interrupt-cells = <1>;
 		ti,sci = <&sms>;
 		ti,sci-dev-id = <148>;
-		ti,interrupt-ranges = <8 360 56>;
+		ti,interrupt-ranges = <8 392 56>;
 	};
 
 	main_pmx0: pinctrl@11c000 {
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1 -1
index 4d1bfabd1313..f0644851602c 100644
@@ -65,7 +65,7 @@
 		#interrupt-cells = <1>;
 		ti,sci = <&sms>;
 		ti,sci-dev-id = <125>;
-		ti,interrupt-ranges = <16 928 16>;
+		ti,interrupt-ranges = <16 960 16>;
 	};
 
 	mcu_conf: syscon@40f00000 {
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 36 lines · Keerthy

The parent's input irq number is wrongly subtracted with 32 instead of using the exact numbers in:

https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html

The GPIO interrupts are not working because of that. The toggling works fine but interrupts are not firing. Fix the parent's input irq that specifies the base for parent irq.

Tested for MAIN_GPIO0_6 interrupt on the j721s2 EVM.

Fixes b8545f9d3a542 ("arm64: dts: ti: Add initial support for J721S2 SoC")
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi       | 2 +-
 arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +1 -1
index 34e7d577ae13..c89f28235812 100644
@@ -60,7 +60,7 @@
 		#interrupt-cells = <1>;
 		ti,sci = <&sms>;
 		ti,sci-dev-id = <148>;
-		ti,interrupt-ranges = <8 360 56>;
+		ti,interrupt-ranges = <8 392 56>;
 	};
 
 	main_pmx0: pinctrl@11c000 {
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +0 -0
index 4d1bfabd1313..f0644851602c 100644

arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi line 68

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1 -1
@@ -65,7 +65,7 @@
 		#interrupt-cells = <1>;
 		ti,sci = <&sms>;
 		ti,sci-dev-id = <125>;
-		ti,interrupt-ranges = <16 928 16>;
+		ti,interrupt-ranges = <16 960 16>;
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +0 -0
 	};
 
 	mcu_conf: syscon@40f00000 {
Signature · 2 lines
Regards,
Vaishnav
maintainer Applied
#2 lore raw
In reply to Keerthy

Hi Keerthy,

Quoted 10 lines · Keerthy

The parent's input irq number is wrongly subtracted with 32 instead of using the exact numbers in:

https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html

The GPIO interrupts are not working because of that. The toggling works fine but interrupts are not firing. Fix the parent's input irq that specifies the base for parent irq.

[...]

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

I have fixed up the commit sha to 12 characters (please do run checkpatch and usual checkers). I am choosing not to send this to 6.1 merge, since nothing actively looks broken requiring urgent fixup atm.

[1/1] arm64: dts: ti: k3-j721s2: Fix the interrupt ranges property for main & wkup gpio intr

      commit: b8aa36c22da7d64c5a5d89ccb4a2abb9aeaab2e3

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D