Skip to contentSkip to conversation

V4L: usbvideo, fix module ref count check

PATCH New Jiri Slaby 1 participant 3 messages Dec 8, 2008 – Dec 22, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 V4L: usbvideo, fix module ref count check

usbvideo_ClientIncModCount may return value < 0 in the case of error, not > 0.

---
 drivers/media/video/usbvideo/usbvideo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/video/usbvideo/usbvideo.c +1 -1
index 7c575bb..6ace064 100644
@@ -1123,7 +1123,7 @@ static int usbvideo_v4l_open(struct inode *inode, struct file *file)
 	if (uvd->debug > 1)
 		dev_info(&uvd->dev->dev, "%s($%p)\n", __func__, dev);
 
-	if (0 < usbvideo_ClientIncModCount(uvd))
+	if (usbvideo_ClientIncModCount(uvd) < 0)
 		return -ENODEV;
 	mutex_lock(&uvd->lock);
 
Signature · 1 line
1.6.0.5
author
#1 lore raw

PATCH 1/2 V4L: usbvideo, fix module ref count check

-ENORESPONSE, CCing akpm

--

usbvideo_ClientIncModCount may return value < 0 in the case of error, not > 0.

Cc Mauro Carvalho Chehab <[email protected]>
---
 drivers/media/video/usbvideo/usbvideo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/video/usbvideo/usbvideo.c +1 -1
index 7c575bb..6ace064 100644
@@ -1123,7 +1123,7 @@ static int usbvideo_v4l_open(struct inode *inode, struct file *file)
 	if (uvd->debug > 1)
 		dev_info(&uvd->dev->dev, "%s($%p)\n", __func__, dev);
 
-	if (0 < usbvideo_ClientIncModCount(uvd))
+	if (usbvideo_ClientIncModCount(uvd) < 0)
 		return -ENODEV;
 	mutex_lock(&uvd->lock);
 
Signature · 1 line
1.6.0.5
author
#2 lore raw

PATCH 2/2 MAINTAINERS: mark linux-uvc-devel as subscribers only

In reply to Jiri Slaby

Posting to linux-uvc-devel is restricted to members. You can subscribe to the list at ...

---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
index d7de513..ec5a7c3 100644
@@ -4571,7 +4571,7 @@ S:	Maintained
 USB VIDEO CLASS
 P:	Laurent Pinchart
 M:	[email protected]
-L:	[email protected]
+L:	[email protected] (subscribers-only)
 L:	[email protected]
 W:	http://linux-uvc.berlios.de
 S:	Maintained
Signature · 1 line
1.6.0.5