Skip to contentSkip to conversation

x86: irqinit_64.c declare init_ISA_irqs before they get used

PATCH In review Jaswinder Singh 2 participants 3 messages Dec 15, 2008 – Dec 16, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: irqinit_64.c declare init_ISA_irqs before they get used

Included asm/arch_hooks.h for init_ISA_irqs

---
 arch/x86/kernel/irqinit_64.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/irqinit_64.c +1 -0
index b33d02f..d1f9663 100644
@@ -21,6 +21,7 @@
 #include <asm/delay.h>
 #include <asm/desc.h>
 #include <asm/apic.h>
+#include <asm/arch_hooks.h>
 #include <asm/i8259.h>
 
 /*
Signature · 1 line
1.5.5.1
#1 lore raw
Quoted 12 lines · Jaswinder Singh

Included asm/arch_hooks.h for init_ISA_irqs

---
 arch/x86/kernel/irqinit_64.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/irqinit_64.c +0 -0
index b33d02f..d1f9663 100644

arch/x86/kernel/irqinit_64.c line 25

Quoted 5 lines
arch/x86/kernel/irqinit_64.c +1 -0
@@ -21,6 +21,7 @@
 #include <asm/delay.h>
 #include <asm/desc.h>
 #include <asm/apic.h>
+#include <asm/arch_hooks.h>
 #include <asm/i8259.h>

not needed.

could change that to static for 64bit.

YH

#2 lore raw
Quoted 5 lines · Yinghai Lu

not needed.

could change that to static for 64bit.

Thanks for your suggestion.

I also CC '[PATCH] x86: irqinit_64.c init_ISA_irqs should be static' to you :-)

Thank you,

Jaswinder Singh.