x86: process.c declare c1e_remove_cpu before they get used
PATCH 1/1 x86: process.c declare c1e_remove_cpu before they get used
Impact: cleanup
Included asm/idle.h for c1e_remove_cpu declaration.
--- arch/x86/kernel/process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/process.c +1 -0
@@ -10,6 +10,7 @@#include <linux/ftrace.h> #include <asm/system.h> #include <asm/apic.h> +#include <asm/idle.h> unsigned long idle_halt;EXPORT_SYMBOL (idle_halt);
Signature · 1 line
1.5.5.1
Quoted 14 lines · Jaswinder Singh
Impact: cleanup
Included
asm/idle.hforc1e_remove_cpudeclaration.Signed-off-by Jaswinder Singh <[email protected]>--- arch/x86/kernel/process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/x86/kernel/process.c +0
-0
arch/x86/kernel/process.c line 16
Quoted 7 lines
arch/x86/kernel/process.c +1
-0@@ -10,6 +10,7 @@#include <linux/ftrace.h> #include <asm/system.h> #include <asm/apic.h> +#include <asm/idle.h> unsigned long idle_halt;EXPORT_SYMBOL (idle_halt);
hm, why is this needed? Have you seen a compiler warning?
Ingo
Quoted 2 lines · Ingo Molnar
hm, why is this needed? Have you seen a compiler warning?
I was getting :
CHECK arch/x86/kernel/process.carch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?
Thank you,
Jaswinder Singh.
Quoted 11 lines · Jaswinder Singh
Quoted 2 lines · Ingo Molnar
hm, why is this needed? Have you seen a compiler warning?
I was getting :
CHECK
arch/x86/kernel/process.carch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?Thank you,
ah, good. Feel free to include such information in future patches. I've applied your patch to tip/x86/cleanups, thanks! See below how the final commit looks like - added the sparse warning as well.
Ingo
--------------->
Quoted 1 line
From
f0bc2202e0373eb8e9b1ddbec930e2e681357db8Mon Sep 17 00:00:00 2001
From: Jaswinder Singh <[email protected]>
Date: Wed, 17 Dec 2008 23:20:05 +0530
Subject: [PATCH] x86: process.c declare c1e_remove_cpu before they get used
Impact: cleanup, avoid sparse warning
Included asm/idle.h for c1e_remove_cpu() declaration. Fixes this sparse warning:
CHECK arch/x86/kernel/process.c
arch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?
--- arch/x86/kernel/process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/process.c +1 -0
@@ -1,6 +1,7 @@#include <linux/errno.h> #include <linux/kernel.h> #include <linux/mm.h> +#include <asm/idle.h> #include <linux/smp.h> #include <linux/slab.h> #include <linux/sched.h>