Skip to contentSkip to conversation

x86: common.c boot_cpu_stack and boot_exception_stacks should be static

PATCH Applied Jaswinder Singh 2 participants 2 messages Dec 19, 2008 x86

lore
Share & tools
lore

Jaswinder Singh

author
#0 lore raw

PATCH 1/1 x86: common.c boot_cpu_stack and boot_exception_stacks should be static

Impact: cleanup, avoid sparse warnings, reduce kernel size a bit

Fixes these sparse warnings:
arch/x86/kernel/cpu/common.c:869:6: warning: symbol 'boot_cpu_stack' was not declared. Should it be static? arch/x86/kernel/cpu/common.c:910:6: warning: symbol 'boot_exception_stacks' was not declared. Should it be static?

Signed-off-by Jaswinder Singh <[email protected]>
---
 arch/x86/kernel/cpu/common.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/common.c +3 -3
index cd7437c..e57a725 100644
@@ -866,7 +866,7 @@ EXPORT_SYMBOL(_cpu_pda);
 
 struct desc_ptr idt_descr = { 256 * 16 - 1, (unsigned long) idt_table };
 
-char boot_cpu_stack[IRQSTACKSIZE] __page_aligned_bss;
+static char boot_cpu_stack[IRQSTACKSIZE] __page_aligned_bss;
 
 void __cpuinit pda_init(int cpu)
 {

@@ -907,8 +907,8 @@ void __cpuinit pda_init(int cpu)
 	}
 }
 
-char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ +
-			   DEBUG_STKSZ] __page_aligned_bss;
+static char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ +
+				  DEBUG_STKSZ] __page_aligned_bss;
 
 extern asmlinkage void ignore_sysret(void);
Signature · 1 line
1.5.5.1
Applied
#1 lore raw
Quoted 10 lines · Jaswinder Singh

Impact: cleanup, avoid sparse warnings, reduce kernel size a bit

Fixes these sparse warnings:
arch/x86/kernel/cpu/common.c:869:6: warning: symbol 'boot_cpu_stack' was not declared. Should it be static? arch/x86/kernel/cpu/common.c:910:6: warning: symbol 'boot_exception_stacks' was not declared. Should it be static?

Signed-off-by Jaswinder Singh <[email protected]>
---
 arch/x86/kernel/cpu/common.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

applied to tip/x86/cleanups, thanks!

Ingo