Skip to contentSkip to conversation

usb-urb.c: Fix initialization of URB list.

PATCH In review Thomas Reitmayr 2 participants 2 messages Dec 29, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Thomas Reitmayr

author
#0 lore raw

PATCH 1/1 usb-urb.c: Fix initialization of URB list.

The following patch was sent to this list back in May 2008
(http://linuxtv.org/pipermail/linux-dvb/2008-May/025952.html) and had a followup of myself in October 2008.
As the kernel oops with USB DVB receivers happens again and again I want to propose to finally apply this patch to the v4l-dvb repository. Thanks,
-Thomas

Signed-off-by Thomas Reitmayr <[email protected]>
drivers/media/dvb/dvb-usb/usb-urb.c +2 -1
@@ -160,7 +160,8 @@ static int usb_bulk_urb_init(struct usb_
 				stream->props.u.bulk.buffersize,
 				usb_urb_complete, stream);
 
-		stream->urb_list[i]->transfer_flags = 0;
+		stream->urb_list[i]->transfer_flags = URB_NO_TRANSFER_DMA_MAP;
+		stream->urb_list[i]->transfer_dma = stream->dma_addr[i];
 		stream->urbs_initialized++;
 	}
 	return 0;

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#1 lore raw

Hi Thomas,

Quoted 13 lines · Thomas Reitmayr

The following patch was sent to this list back in May 2008
(http://linuxtv.org/pipermail/linux-dvb/2008-May/025952.html) and had a followup of myself in October 2008.
As the kernel oops with USB DVB receivers happens again and again I want to propose to finally apply this patch to the v4l-dvb repository. Thanks,
-Thomas

Signed-off-by Thomas Reitmayr <[email protected]>

drivers/media/dvb/dvb-usb/usb-urb.c static int usb_bulk_urb_init(struct usb_ · line 167

Quoted 9 lines
drivers/media/dvb/dvb-usb/usb-urb.c +2 -1
@@ -160,7 +160,8 @@ static int usb_bulk_urb_init(struct usb_
 				stream->props.u.bulk.buffersize,
 				usb_urb_complete, stream);
 
-		stream->urb_list[i]->transfer_flags = 0;
+		stream->urb_list[i]->transfer_flags = URB_NO_TRANSFER_DMA_MAP;
+		stream->urb_list[i]->transfer_dma = stream->dma_addr[i];
 		stream->urbs_initialized++;
 	}
 	return 0;

Committed and ask for pull request.

Thanks and sorry for the delay.

Patrick.

--
Mail: [email protected]
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb