sched: sched.c declare variables before they get used
PATCH 1/1 sched: sched.c declare variables before they get used
Impact: cleanup, avoid sparse warnings
In linux/sched.h moved out sysctl_sched_latency, sysctl_sched_min_granularity, sysctl_sched_wakeup_granularity, sysctl_sched_shares_ratelimit and sysctl_sched_shares_thresh from #ifdef CONFIG_SCHED_DEBUG as these variables are common for both.
Fixes these sparse warnings:kernel/sched.c:825:14: warning: symbol 'sysctl_sched_shares_ratelimit' was not declared. Should it be static? kernel/sched.c:832:14: warning: symbol 'sysctl_sched_shares_thresh' was not declared. Should it be static? kernel/sched_fair.c:37:14: warning: symbol 'sysctl_sched_latency' was not declared. Should it be static? kernel/sched_fair.c:43:14: warning: symbol 'sysctl_sched_min_granularity' was not declared. Should it be static? kernel/sched_fair.c:72:14: warning: symbol 'sysctl_sched_wakeup_granularity' was not declared. Should it be static?
--- include/linux/sched.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
include/linux/sched.h +3 -3
@@ -1707,16 +1707,16 @@ extern void wake_up_idle_cpu(int cpu);static inline void wake_up_idle_cpu (int cpu) { }#endif -#ifdef CONFIG_SCHED_DEBUG extern unsigned int sysctl_sched_latency;extern unsigned int sysctl_sched_min_granularity;extern unsigned int sysctl_sched_wakeup_granularity; +extern unsigned int sysctl_sched_shares_ratelimit; +extern unsigned int sysctl_sched_shares_thresh; +#ifdef CONFIG_SCHED_DEBUG extern unsigned int sysctl_sched_child_runs_first;extern unsigned int sysctl_sched_features;extern unsigned int sysctl_sched_migration_cost;extern unsigned int sysctl_sched_nr_migrate; -extern unsigned int sysctl_sched_shares_ratelimit; -extern unsigned int sysctl_sched_shares_thresh; int sched_nr_latency_handler(struct ctl_table *table, int write, struct file *file, void __user *buffer, size_t *length,
Signature · 1 line
1.5.5.1
Ingo Molnar
AppliedQuoted 14 lines · Jaswinder Singh Rajput
Impact: cleanup, avoid sparse warnings
In
linux/sched.hmoved outsysctl_sched_latency,sysctl_sched_min_granularity,sysctl_sched_wakeup_granularity,sysctl_sched_shares_ratelimitandsysctl_sched_shares_threshfrom #ifdefCONFIG_SCHED_DEBUGas these variables are common for both.Fixes these sparse warnings:
kernel/sched.c:825:14: warning: symbol 'sysctl_sched_shares_ratelimit' was not declared. Should it be static?kernel/sched.c:832:14: warning: symbol 'sysctl_sched_shares_thresh' was not declared. Should it be static?kernel/sched_fair.c:37:14: warning: symbol 'sysctl_sched_latency' was not declared. Should it be static?kernel/sched_fair.c:43:14: warning: symbol 'sysctl_sched_min_granularity' was not declared. Should it be static?kernel/sched_fair.c:72:14: warning: symbol 'sysctl_sched_wakeup_granularity' was not declared. Should it be static?
Quoted 4 lines
Signed-off-by Jaswinder Singh Rajput <[email protected]>--- include/linux/sched.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
applied to tip/sched/cleanups, thanks!
Ingo