Skip to contentSkip to conversation

gspca: fix codingstyle in sd_mod_init

PATCH New Alexey Klimov 1 participant 1 message Jan 1, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Alexey Klimov

author
#0 lore raw

PATCH 1/1 gspca: fix codingstyle in sd_mod_init

Hello, Jean-Francois
What do you think about this patch ?

Fix CodingStyle in sd_mod_init function in all gspca drivers. Introduce int ret and check it value after call to usb_register().

Signed-off-by Alexey Klimov <[email protected]>

---

linux/drivers/media/video/gspca/conex.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/conex.c
@@ -1028,7 +1028,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/etoms.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/etoms.c
@@ -933,7 +933,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/finepix.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/finepix.c
@@ -454,7 +454,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/m5602/m5602_core.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/m5602/m5602_core.c
@@ -373,7 +373,9 @@
 /* -- module insert / remove -- */
 static int __init mod_m5602_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/mars.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/mars.c
@@ -420,7 +420,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/ov519.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/ov519.c
@@ -2201,7 +2201,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/ov534.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/ov534.c
@@ -584,7 +584,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/pac207.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/pac207.c
@@ -564,7 +564,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/pac7311.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/pac7311.c
@@ -1110,7 +1110,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/sonixb.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/sonixb.c
@@ -1301,7 +1301,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/sonixj.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/sonixj.c
@@ -1809,7 +1809,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	info("registered");
 	return 0;
linux/drivers/media/video/gspca/spca500.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca500.c
@@ -1109,7 +1109,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/spca501.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca501.c
@@ -2258,7 +2258,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/spca505.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca505.c
@@ -931,7 +931,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/spca506.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca506.c
@@ -771,7 +771,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/spca508.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca508.c
@@ -1703,7 +1703,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/spca561.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca561.c
@@ -1203,7 +1203,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/stk014.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/stk014.c
@@ -560,7 +560,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	info("registered");
 	return 0;
linux/drivers/media/video/gspca/stv06xx/stv06xx.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
@@ -500,7 +500,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/sunplus.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/sunplus.c
@@ -1495,7 +1495,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/t613.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/t613.c
@@ -1175,7 +1175,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/tv8532.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/tv8532.c
@@ -578,7 +578,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/vc032x.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/vc032x.c
@@ -2485,7 +2485,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
linux/drivers/media/video/gspca/zc3xx.c +3 -1
diff -r b9092fca16f0 linux/drivers/media/video/gspca/zc3xx.c
@@ -7608,7 +7608,9 @@
 
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
Signature · 6 lines
Best regards, Klimov Alexey

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list