x86: nmi.c fix style problems
PATCH 1/1 x86: nmi.c fix style problems
Impact: cleanup, fix style problems
Fixes style problems:
WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
WARNING: Use #include <linux/nmi.h> instead of <asm/nmi.h>
total: 0 errors, 2 warnings
Signed-off-by Jaswinder Singh Rajput <[email protected]>
--- arch/x86/kernel/nmi.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/x86/kernel/nmi.c +1 -2
@@ -26,11 +26,10 @@#include <linux/kernel_stat.h> #include <linux/kdebug.h> #include <linux/smp.h> +#include <linux/nmi.h> #include <asm/i8259.h> #include <asm/io_apic.h> -#include <asm/smp.h> -#include <asm/nmi.h> #include <asm/proto.h> #include <asm/timer.h>
Signature · 1 line
1.5.5.1
Quoted 19 lines · Jaswinder Singh Rajput
Impact: cleanup, fix style problems
Fixes style problems:
WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
WARNING: Use #include <linux/nmi.h> instead of <asm/nmi.h>total: 0 errors, 2 warnings
Signed-off-by Jaswinder Singh Rajput <[email protected]>--- arch/x86/kernel/nmi.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)arch/x86/kernel/nmi.c +0
-0@@ -26,11 +26,10 @@#include <linux/kernel_stat.h>
arch/x86/kernel/nmi.c line 34
Quoted 10 lines
arch/x86/kernel/nmi.c +1
-2#include <linux/kdebug.h> #include <linux/smp.h> +#include <linux/nmi.h> #include <asm/i8259.h> #include <asm/io_apic.h> -#include <asm/smp.h> -#include <asm/nmi.h> #include <asm/proto.h> #include <asm/timer.h>
does this build fine on UP + IOAPIC ? asm/smp.h has some side-effects that brings in certain APIC definitions.
Ingo
Quoted 3 lines · Ingo Molnar
does this build fine on UP + IOAPIC ?
asm/smp.hhas some side-effects that brings in certain APIC definitions.
Yes, it works fine for me.
JSR