Skip to contentSkip to conversation

__must_check btrfs_alloc_path()

PATCH In review Diego Calleja 2 participants 2 messages Dec 29, 2008 – Jan 5, 2009 Btrfs file system

lore
Share & tools
lore

Diego Calleja

author
#0 lore raw

PATCH 1/1 __must_check btrfs_alloc_path()

IMHO it's a good thing to add __must_check in new code where it has sense.

ctree.c +1 -1
Index: btrfs-unstable-standalone/ctree.c
===================================================================
@@ -43,7 +43,7 @@
 	memset(p, 0, sizeof(*p));
 }
 
-struct btrfs_path *btrfs_alloc_path(void)
+struct btrfs_path __must_check *btrfs_alloc_path(void)
 {
 	struct btrfs_path *path;
 	path = kmem_cache_alloc(btrfs_path_cachep, GFP_NOFS);
#1 lore raw
Quoted 3 lines · Diego Calleja

IMHO it's a good thing to add __must_check in new code where it has sense.

I don't think we'll pass this one yet ;) But you're right that it is a good idea to start adding it to other functions.

-chris