Skip to contentSkip to conversation

gianfar: ensure ECNTRL[R100] is cleared on link state change

PATCH Applied Kumar Gala 3 participants 3 messages Jan 6, 2009

Subsystems (2)
lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 gianfar: ensure ECNTRL[R100] is cleared on link state change

From: Leo Li <[email protected]>

When changing the link between 100Mbps and 1Gbps in SGMII mode it was found out that the link would stop working. The issue is that ECNTRL[R100] needs to be cleared when in 1Gbps mode. Older reference manuals didn't require the explicitly clearing but has since been found it that it is needed.

---

Dave,

Please apply for 2.6.29 as it addresses a "HW" bug in real systems.

thanks

- k

 drivers/net/gianfar.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/gianfar.c +2 -0
index c672ecf..7fcc3af 100644
@@ -1973,6 +1973,8 @@ static void adjust_link(struct net_device *dev)
 			case 1000:
 				tempval =
 				    ((tempval & ~(MACCFG2_IF)) | MACCFG2_GMII);
+
+				ecntrl &= ~(ECNTRL_R100);
 				break;
 			case 100:
 			case 10:
Signature · 1 line
1.5.6.5
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Kumar Gala

From: Leo Li <[email protected]>

When changing the link between 100Mbps and 1Gbps in SGMII mode it was found out that the link would stop working. The issue is that ECNTRL[R100] needs to be cleared when in 1Gbps mode. Older reference manuals didn't require the explicitly clearing but has since been found it that it is needed.

maintainer Applied
#2 lore raw

From: Andy Fleming <[email protected]>
Date: Tue, 6 Jan 2009 14:56:25 -0600

Quoted 11 lines · Kumar Gala
Quoted 9 lines

From: Leo Li <[email protected]>

When changing the link between 100Mbps and 1Gbps in SGMII mode it was found out that the link would stop working. The issue is that ECNTRL[R100] needs to be cleared when in 1Gbps mode. Older reference manuals didn't require the explicitly clearing but has since been found it that it is needed.

Quoted 4 lines
Quoted 2 lines

Applied, thanks everyone.