Skip to contentSkip to conversation

powerpc: Fix missing semicolons in mmu_decl.h

PATCH In review Benjamin Herrenschmidt 2 participants 3 messages Jan 7, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Fix missing semicolons in mmu_decl.h

This is a brown paper bag from one of my earlier patches that breaks build on 40x and 8xx.

And yes, I've now added 40x and 8xx to my list of test configs :-)

---

 arch/powerpc/mm/mmu_decl.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/mm/mmu_decl.h +3 -3
@@ -30,11 +30,11 @@
 #if defined(CONFIG_40x) || defined(CONFIG_8xx)
 static inline void _tlbil_all(void)
 {
-	asm volatile ("sync; tlbia; isync" : : : "memory")
+	asm volatile ("sync; tlbia; isync" : : : "memory");
 }
 static inline void _tlbil_pid(unsigned int pid)
 {
-	asm volatile ("sync; tlbia; isync" : : : "memory")
+	asm volatile ("sync; tlbia; isync" : : : "memory");
 }
 #else /* CONFIG_40x || CONFIG_8xx */
 extern void _tlbil_all(void);
@@ -47,7 +47,7 @@ extern void _tlbil_pid(unsigned int pid)
 #ifdef CONFIG_8xx
 static inline void _tlbil_va(unsigned long address, unsigned int pid)
 {
-	asm volatile ("tlbie %0; sync" : : "r" (address) : "memory")
+	asm volatile ("tlbie %0; sync" : : "r" (address) : "memory");
 }
 #else /* CONFIG_8xx */
 extern void _tlbil_va(unsigned long address, unsigned int pid);
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Benjamin Herrenschmidt

This is a brown paper bag from one of my earlier patches that breaks build on 40x and 8xx.

And yes, I've now added 40x and 8xx to my list of test configs :-)

Please get it into your tree so people stop emailing me about it being broken :).

josh

Quoted 34 lines

---

arch/powerpc/mm/mmu_decl.h | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/mm/mmu_decl.h +3 -3
@@ -30,11 +30,11 @@
 #if defined(CONFIG_40x) || defined(CONFIG_8xx)
 static inline void _tlbil_all(void)
 {
-	asm volatile ("sync; tlbia; isync" : : : "memory")
+	asm volatile ("sync; tlbia; isync" : : : "memory");
 }
 static inline void _tlbil_pid(unsigned int pid)
 {
-	asm volatile ("sync; tlbia; isync" : : : "memory")
+	asm volatile ("sync; tlbia; isync" : : : "memory");
 }
 #else /* CONFIG_40x || CONFIG_8xx */
 extern void _tlbil_all(void);
@@ -47,7 +47,7 @@ extern void _tlbil_pid(unsigned int pid)
 #ifdef CONFIG_8xx
 static inline void _tlbil_va(unsigned long address, unsigned int pid)
 {
-	asm volatile ("tlbie %0; sync" : : "r" (address) : "memory")
+	asm volatile ("tlbie %0; sync" : : "r" (address) : "memory");
 }
 #else /* CONFIG_8xx */
 extern void _tlbil_va(unsigned long address, unsigned int pid);

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

#2 lore raw
Quoted 4 lines · Josh Boyer
Quoted 3 lines · Benjamin Herrenschmidt

This is a brown paper bag from one of my earlier patches that breaks build on 40x and 8xx.

Quoted 8 lines
Quoted 3 lines

And yes, I've now added 40x and 8xx to my list of test configs :-)

Please get it into your tree so people stop emailing me about it being broken :).

It's in, waiting for me to push. I didn't have a chance yesterday due to other problems but hopefully, after I do a few boot tests today, I'll push out.

Ben.