Skip to contentSkip to conversation

powerpc: numa: avoid possible reference beyond property length in find_min_common_depth

PATCH New Milton Miller 1 participant 1 message Jan 8, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 4/4 powerpc: numa: avoid possible reference beyond property length in find_min_common_depth

find_min_common_depth was checking the property length incorrectly. The value is in bytes not cells, and it is using the second entry.

---
I'm not aware of any trees that are broken in this way, so backport not likely needed but easy to apply.

arch/powerpc/mm/numa.c +1 -1
Index: work.git/arch/powerpc/mm/numa.c
===================================================================
@@ -260,7 +260,7 @@ static int __init find_min_common_depth(
 	ref_points = of_get_property(rtas_root,
 			"ibm,associativity-reference-points", &len);
 
-	if ((len >= 1) && ref_points) {
+	if ((len >= 2 * sizeof(unsigned int)) && ref_points) {
 		depth = ref_points[1];
 	} else {
 		dbg("NUMA: ibm,associativity-reference-points not found.\n");