Skip to contentSkip to conversation

wimax: fix compile bug

PATCH In review Heiko Carstens 5 participants 7 messages Jan 8, 2009 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wimax: fix compile bug

From: Heiko Carstens <[email protected]>

wimax should depend on INPUT:

net/built-in.o: In function `wimax_rfkill_rm':
linux-2.6/net/wimax/op-rfkill.c:428: undefined reference to input_unregister_device' net/built-in.o: In function wimax_rfkill_add':
linux-2.6/net/wimax/op-rfkill.c:370: undefined reference to input_allocate_device' linux-2.6/net/wimax/op-rfkill.c:384: undefined reference to input_register_device' linux-2.6/net/wimax/op-rfkill.c:402: undefined reference to input_unregister_device' linux-2.6/net/wimax/op-rfkill.c:406: undefined reference to input_free_device' net/built-in.o: In function `input_report_key':
linux-2.6/include/linux/input.h:1285: undefined reference to `input_event'

Cc Inaky Perez-Gonzalez <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 net/wimax/Kconfig |    1 +
 1 file changed, 1 insertion(+)
net/wimax/Kconfig +1 -0
Index: linux-2.6/net/wimax/Kconfig
===================================================================
@@ -4,6 +4,7 @@
 
 menuconfig WIMAX
 	tristate "WiMAX Wireless Broadband support"
+	depends on INPUT
 	help
 
 	  Select to configure support for devices that provide
#1 lore raw
Quoted 3 lines · Heiko Carstens

From: Heiko Carstens <[email protected]>

wimax should depend on INPUT:

<snip>

Inaky just sent a series of 3 patches to the netdev mailing list fixing this up in a much better way.

thanks,

greg k-h

maintainer
#2 lore raw

From: Greg KH <[email protected]>
Date: Thu, 8 Jan 2009 08:52:54 -0800

Quoted 9 lines · Heiko Carstens
Quoted 3 lines

From: Heiko Carstens <[email protected]>

wimax should depend on INPUT:

<snip>

Inaky just sent a series of 3 patches to the netdev mailing list fixing this up in a much better way.

Yep, I'll be integrating his patches during the course of today.

#3 lore raw
Quoted 8 lines · David Miller

From: Greg KH <[email protected]>
Date: Thu, 8 Jan 2009 08:52:54 -0800

Quoted 5 lines · Heiko Carstens
Quoted 3 lines

From: Heiko Carstens <[email protected]>

wimax should depend on INPUT:

Quoted 7 lines
Quoted 4 lines

<snip>

Inaky just sent a series of 3 patches to the netdev mailing list fixing this up in a much better way.

Yep, I'll be integrating his patches during the course of today.

Even better. Thanks!

#4 lore raw
In reply to David Miller
Quoted 8 lines · David Miller

From: Greg KH <[email protected]>
Date: Thu, 8 Jan 2009 08:52:54 -0800

Quoted 5 lines · Heiko Carstens
Quoted 3 lines

From: Heiko Carstens <[email protected]>

wimax should depend on INPUT:

Quoted 7 lines
Quoted 4 lines

<snip>

Inaky just sent a series of 3 patches to the netdev mailing list fixing this up in a much better way.

Yep, I'll be integrating his patches during the course of today.

Thanks David

Please be sure to integrate v3 of the patchset
(http://lkml.org/lkml/2009/1/7/397), shows as the 1/4 series in patchwork.ozlabs.org.

Signature · 1 line
Inaky
#6 lore raw
In reply to Heiko Carstens

Hi Heiko,

Quoted 12 lines

wimax should depend on INPUT:

net/built-in.o: In function `wimax_rfkill_rm':
linux-2.6/net/wimax/op-rfkill.c:428: undefined reference to input_unregister_device' net/built-in.o: In function wimax_rfkill_add':
linux-2.6/net/wimax/op-rfkill.c:370: undefined reference to input_allocate_device' linux-2.6/net/wimax/op-rfkill.c:384: undefined reference to input_register_device' linux-2.6/net/wimax/op-rfkill.c:402: undefined reference to input_unregister_device' linux-2.6/net/wimax/op-rfkill.c:406: undefined reference to input_free_device' net/built-in.o: In function `input_report_key':
linux-2.6/include/linux/input.h:1285: undefined reference to `input_event'

Quoted 3 lines
Cc Inaky Perez-Gonzalez <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

actually Inaky posted a different fix for this to netdev yesterday.

Regards

Marcel